From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org
Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH v2 4/7] erofs: implement .read_iter for page cache sharing
Date: Wed, 11 Jan 2023 16:31:55 +0800 [thread overview]
Message-ID: <20230111083158.23462-5-jefflexu@linux.alibaba.com> (raw)
In-Reply-To: <20230111083158.23462-1-jefflexu@linux.alibaba.com>
When page cache sharing enabled, page caches are managed in the address
space of blobs rather than erofs inodes. All erofs inodes sharing one
chunk will refer to and share the page cache in the blob's address
space.
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
fs/erofs/fscache.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index f715b3efcc77..4075d9519a7d 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -384,8 +384,56 @@ static int erofs_fscache_share_file_open(struct inode *inode, struct file *filp)
return 0;
}
+static ssize_t erofs_fscache_share_file_read_iter(struct kiocb *iocb,
+ struct iov_iter *to)
+{
+ struct file *filp = iocb->ki_filp;
+ struct inode *inode = file_inode(filp);
+ struct file *realfile = filp->private_data;
+ struct inode *realinode = file_inode(realfile);
+ struct erofs_fscache_share_file_info *finfo = realfile->private_data;
+ ssize_t already_read = 0;
+ int ret = 0;
+
+ /* no need taking (shared) inode lock since it's a ro filesystem */
+ if (!iov_iter_count(to))
+ return 0;
+
+ if (IS_DAX(inode) || iocb->ki_flags & IOCB_DIRECT)
+ return -EOPNOTSUPP;
+
+ do {
+ struct folio *folio;
+ size_t bytes, copied, offset, fsize;
+ pgoff_t index = (finfo->pa + iocb->ki_pos) >> PAGE_SHIFT;
+
+ folio = read_cache_folio(realinode->i_mapping, index, NULL, NULL);
+ if (IS_ERR(folio)) {
+ ret = PTR_ERR(folio);
+ break;
+ }
+
+ fsize = folio_size(folio);
+ offset = iocb->ki_pos & (fsize - 1);
+ bytes = min_t(size_t, inode->i_size - iocb->ki_pos, iov_iter_count(to));
+ bytes = min_t(size_t, bytes, fsize - offset);
+ copied = copy_folio_to_iter(folio, offset, bytes, to);
+ folio_put(folio);
+ iocb->ki_pos += copied;
+ already_read += copied;
+ if (copied < bytes) {
+ ret = -EFAULT;
+ break;
+ }
+ } while (iov_iter_count(to) && iocb->ki_pos < inode->i_size);
+
+ file_accessed(filp);
+ return already_read ? already_read : ret;
+}
+
const struct file_operations erofs_fscache_share_file_fops = {
.llseek = generic_file_llseek,
+ .read_iter = erofs_fscache_share_file_read_iter,
.open = erofs_fscache_share_file_open,
.release = erofs_fscache_share_file_release,
};
--
2.19.1.6.gb485710b
next prev parent reply other threads:[~2023-01-11 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:31 [PATCH v2 0/7] erofs: support page cache sharing between EROFS images in fscache mode Jingbo Xu
2023-01-11 8:31 ` [PATCH v2 1/7] erofs: remove unused device mapping in the meta routine Jingbo Xu
2023-01-11 8:31 ` [PATCH v2 2/7] erofs: unify anonymous inodes for blob Jingbo Xu
2023-01-11 8:31 ` [PATCH v2 3/7] erofs: allocate anonymous file of blob for page cache sharing Jingbo Xu
2023-01-11 8:31 ` Jingbo Xu [this message]
2023-01-11 8:31 ` [PATCH v2 5/7] erofs: implement .mmap " Jingbo Xu
2023-01-11 8:31 ` [PATCH v2 6/7] erofs: add helper checking if page cache sharing shall be enabled Jingbo Xu
2023-01-11 8:31 ` [PATCH v2 7/7] erofs: introduce 'sharecache' mount option Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111083158.23462-5-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).