From: Chao Yu <chao@kernel.org>
To: akpm@linux-foundation.org, adobriyan@gmail.com
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH] proc: remove mark_inode_dirty() in proc_notify_change()
Date: Thu, 12 Jan 2023 11:27:20 +0800 [thread overview]
Message-ID: <20230112032720.1855235-1-chao@kernel.org> (raw)
proc_notify_change() has updated i_uid, i_gid and i_mode into proc
dirent, we don't need to call mark_inode_dirty() for later writeback,
remove it.
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/proc/generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 5f52f20d5ed1..f547e9593a77 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -127,7 +127,6 @@ static int proc_notify_change(struct user_namespace *mnt_userns,
return error;
setattr_copy(&init_user_ns, inode, iattr);
- mark_inode_dirty(inode);
proc_set_user(de, inode->i_uid, inode->i_gid);
de->mode = inode->i_mode;
--
2.25.1
next reply other threads:[~2023-01-12 3:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 3:27 Chao Yu [this message]
2023-01-12 22:43 ` [PATCH] proc: remove mark_inode_dirty() in proc_notify_change() Andrew Morton
2023-01-29 14:58 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112032720.1855235-1-chao@kernel.org \
--to=chao@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).