From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB1EC54EBC for ; Thu, 12 Jan 2023 12:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbjALMHu (ORCPT ); Thu, 12 Jan 2023 07:07:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbjALMHE (ORCPT ); Thu, 12 Jan 2023 07:07:04 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D804C762 for ; Thu, 12 Jan 2023 04:01:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 56D9334A31; Thu, 12 Jan 2023 12:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673524918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Jnv7AxT2AW1qUNGcOFAcNJ68VOaO6yli3UdH9+R8r8=; b=eSkMLM6Ep5LO5WhAEh36iJl8EhFEfeofZ4ZTiccZUS4FbtvHLI2g3EAVhPsvzDB/UbLa7e TFDjMfOad/QQlKivJlGPfW/0KcTC8w1vmxE1w5fT6+zRLLA24RT6cc9ONjmZB9ORoVyK1s ERDBDxWX83C1Ihnn9ED+RvabqvSovjk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673524918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9Jnv7AxT2AW1qUNGcOFAcNJ68VOaO6yli3UdH9+R8r8=; b=zErymu8GCywBbtT82CEGRdVi6XsFTq6wBykRYpiBiASp0pHsGUr/Wwnj9ynuXrTq8PiNNY ssyqHI93o1Ukb7AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 48F6813585; Thu, 12 Jan 2023 12:01:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eMnGEbb2v2M8PQAAMHmgww (envelope-from ); Thu, 12 Jan 2023 12:01:58 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C3767A0744; Thu, 12 Jan 2023 13:01:57 +0100 (CET) Date: Thu, 12 Jan 2023 13:01:57 +0100 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 00/12] Start converting buffer_heads to use folios Message-ID: <20230112120157.7z4lq4enb4rkwc4f@quack3> References: <20221215214402.3522366-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221215214402.3522366-1-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu 15-12-22 21:43:50, Matthew Wilcox (Oracle) wrote: > I was hoping that filesystems would convert from buffer_heads to iomap, > but that's not happening particularly quickly. So the buffer_head > infrastructure needs to be converted from being page-based to being > folio-based. This is the initial patchset that I hope Andrew will take > for 6.3. I have a lot of followup patches, but many of them should go > through individual filesystem trees (ext4, f2fs, etc). They can wait > for 6.4. FWIW I went through all the patches and they look fine to me so feel free to add: Reviewed-by: Jan Kara Honza > > Matthew Wilcox (Oracle) (12): > buffer: Add b_folio as an alias of b_page > buffer: Replace obvious uses of b_page with b_folio > buffer: Use b_folio in touch_buffer() > buffer: Use b_folio in end_buffer_async_read() > buffer: Use b_folio in end_buffer_async_write() > page_io: Remove buffer_head include > buffer: Use b_folio in mark_buffer_dirty() > gfs2: Replace obvious uses of b_page with b_folio > jbd2: Replace obvious uses of b_page with b_folio > nilfs2: Replace obvious uses of b_page with b_folio > reiserfs: Replace obvious uses of b_page with b_folio > mpage: Use b_folio in do_mpage_readpage() > > fs/buffer.c | 54 +++++++++++++++++------------------ > fs/gfs2/glops.c | 2 +- > fs/gfs2/log.c | 2 +- > fs/gfs2/meta_io.c | 2 +- > fs/jbd2/commit.c | 8 ++---- > fs/jbd2/journal.c | 2 +- > fs/mpage.c | 2 +- > fs/nilfs2/btnode.c | 2 +- > fs/nilfs2/btree.c | 2 +- > fs/nilfs2/gcinode.c | 2 +- > fs/nilfs2/mdt.c | 4 +-- > fs/nilfs2/segment.c | 2 +- > fs/reiserfs/journal.c | 4 +-- > fs/reiserfs/tail_conversion.c | 2 +- > include/linux/buffer_head.h | 5 +++- > mm/page_io.c | 1 - > 16 files changed, 47 insertions(+), 49 deletions(-) > > -- > 2.35.1 > -- Jan Kara SUSE Labs, CR