From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A2A0C67871 for ; Thu, 12 Jan 2023 14:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232838AbjALOCO (ORCPT ); Thu, 12 Jan 2023 09:02:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232256AbjALOCE (ORCPT ); Thu, 12 Jan 2023 09:02:04 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAA3F4BD4C; Thu, 12 Jan 2023 06:02:03 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id A997768BEB; Thu, 12 Jan 2023 15:01:59 +0100 (CET) Date: Thu, 12 Jan 2023 15:01:59 +0100 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Qu Wenruo , Jens Axboe , "Darrick J. Wong" , "linux-block@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH 06/19] btrfs: handle recording of zoned writes in the storage layer Message-ID: <20230112140159.GA6416@lst.de> References: <20230112090532.1212225-1-hch@lst.de> <20230112090532.1212225-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jan 12, 2023 at 10:31:49AM +0000, Johannes Thumshirn wrote: > What base is this against? I'm getting the following: > Applying: btrfs: handle recording of zoned writes in the storage layer > fs/btrfs/inode.c: In function ‘btrfs_submit_direct’: > fs/btrfs/inode.c:7842:25: error: label ‘out_err’ used but not defined > 7842 | goto out_err; > | ^~~~ > > > Specifically that hunk needs to be removed: Yes, it needs to be removed. I didn't properly complile test this step after the lastest rebased that added another users of out_err. It gets fixed later on, but I've force pushed the tree mentioned in the cover letter to fix it up at this stage as well.