From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"
Date: Sat, 21 Jan 2023 15:29:27 +0100 [thread overview]
Message-ID: <20230121142927.GB6786@lst.de> (raw)
In-Reply-To: <20230120141150.1278819-1-agruenba@redhat.com>
> + struct address_space *mapping = data;
> + int ret = mapping->a_ops->writepage(page, wbc);
> + mapping_set_error(mapping, ret);
> + return ret;
I guess beggars can't be choosers, but is there a chance to directly
call the relevant gfs2 writepage methods here instead of the
->writepage call?
Otherwise this looks good:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-01-21 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 14:11 [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one" Andreas Gruenbacher
2023-01-21 14:29 ` Christoph Hellwig [this message]
2023-01-22 8:48 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230121142927.GB6786@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).