From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968BEC004D4 for ; Sat, 21 Jan 2023 14:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229776AbjAUO3c (ORCPT ); Sat, 21 Jan 2023 09:29:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjAUO3b (ORCPT ); Sat, 21 Jan 2023 09:29:31 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBDF01F5FF for ; Sat, 21 Jan 2023 06:29:30 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 3598568CFE; Sat, 21 Jan 2023 15:29:28 +0100 (CET) Date: Sat, 21 Jan 2023 15:29:27 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , Bob Peterson , linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH] Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one" Message-ID: <20230121142927.GB6786@lst.de> References: <20230120141150.1278819-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120141150.1278819-1-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > + struct address_space *mapping = data; > + int ret = mapping->a_ops->writepage(page, wbc); > + mapping_set_error(mapping, ret); > + return ret; I guess beggars can't be choosers, but is there a chance to directly call the relevant gfs2 writepage methods here instead of the ->writepage call? Otherwise this looks good: Acked-by: Christoph Hellwig