From: Christoph Hellwig <hch@lst.de>
To: syzbot <syzbot+c27475eb921c46bbdc62@syzkaller.appspotmail.com>
Cc: akpm@linux-foundation.org, hch@lst.de, jack@suse.com,
jack@suse.cz, linkinjeon@gmail.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, syzkaller-bugs@googlegroups.com,
willy@infradead.org
Subject: Re: [syzbot] [udf?] BUG: unable to handle kernel NULL pointer dereference in __writepage
Date: Mon, 23 Jan 2023 08:36:09 +0100 [thread overview]
Message-ID: <20230123073609.GA31134@lst.de> (raw)
In-Reply-To: <0000000000009cfc1705f2a07641@google.com>
I looked into this and got really confused. We should never end
up in generic_writepages if ->writepages is set, which this patch
obviously does.
Then I took a closer look at udf, and it seems to switch a_aops around
at run time, and it seems like we're hitting just that case, and the
patch just seems to narrow down that window.
I suspect the right fix is to remove this runtime switching of aops,
and just do conditionals inside the methods.
next prev parent reply other threads:[~2023-01-23 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 15:04 [syzbot] [udf?] BUG: unable to handle kernel NULL pointer dereference in __writepage syzbot
2023-01-19 16:31 ` syzbot
2023-01-23 7:36 ` Christoph Hellwig [this message]
2023-01-23 17:18 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123073609.GA31134@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+c27475eb921c46bbdc62@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).