linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Jeff Layton <jlayton@kernel.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	linux-mm@kvack.org
Subject: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down
Date: Mon, 23 Jan 2023 17:30:07 +0000	[thread overview]
Message-ID: <20230123173007.325544-11-dhowells@redhat.com> (raw)
In-Reply-To: <20230123173007.325544-1-dhowells@redhat.com>

Renumber FOLL_PIN and FOLL_GET down to bit 0 and 1 respectively so that
they are coincidentally the same as BIO_PAGE_PINNED and BIO_PAGE_REFFED and
also so that they can be stored in the bottom two bits of a page pointer
(something I'm looking at for zerocopy socket fragments).

(Note that BIO_PAGE_REFFED should probably be got rid of at some point,
hence why FOLL_PIN is at 0.)

Also renumber down the other FOLL_* flags to close the gaps.

Signed-off-by: David Howells <dhowells@redhat.com>
cc: Al Viro <viro@zeniv.linux.org.uk>
cc: Christoph Hellwig <hch@lst.de>
cc: Matthew Wilcox <willy@infradead.org>
cc: linux-fsdevel@vger.kernel.org
cc: linux-mm@kvack.org
---

Notes:
    ver #8)
     - Put FOLL_PIN at bit 0 and FOLL_GET at bit 1 to match BIO_PAGE_*.
     - Renumber the remaining flags down to fill in the gap.

 include/linux/mm.h | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 3de9d88f8524..c95bc4f77e8f 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -3074,26 +3074,28 @@ static inline vm_fault_t vmf_error(int err)
 struct page *follow_page(struct vm_area_struct *vma, unsigned long address,
 			 unsigned int foll_flags);
 
-#define FOLL_WRITE	0x01	/* check pte is writable */
-#define FOLL_TOUCH	0x02	/* mark page accessed */
-#define FOLL_GET	0x04	/* do get_page on page */
-#define FOLL_DUMP	0x08	/* give error on hole if it would be zero */
-#define FOLL_FORCE	0x10	/* get_user_pages read/write w/o permission */
-#define FOLL_NOWAIT	0x20	/* if a disk transfer is needed, start the IO
+#define FOLL_PIN	0x01	/* pages must be released via unpin_user_page */
+#define FOLL_GET	0x02	/* do get_page on page (equivalent to BIO_FOLL_GET) */
+#define FOLL_WRITE	0x04	/* check pte is writable */
+#define FOLL_TOUCH	0x08	/* mark page accessed */
+#define FOLL_DUMP	0x10	/* give error on hole if it would be zero */
+#define FOLL_FORCE	0x20	/* get_user_pages read/write w/o permission */
+#define FOLL_NOWAIT	0x40	/* if a disk transfer is needed, start the IO
 				 * and return without waiting upon it */
 #define FOLL_NOFAULT	0x80	/* do not fault in pages */
 #define FOLL_HWPOISON	0x100	/* check page is hwpoisoned */
-#define FOLL_TRIED	0x800	/* a retry, previous pass started an IO */
-#define FOLL_REMOTE	0x2000	/* we are working on non-current tsk/mm */
-#define FOLL_ANON	0x8000	/* don't do file mappings */
-#define FOLL_LONGTERM	0x10000	/* mapping lifetime is indefinite: see below */
-#define FOLL_SPLIT_PMD	0x20000	/* split huge pmd before returning */
-#define FOLL_PIN	0x40000	/* pages must be released via unpin_user_page */
-#define FOLL_FAST_ONLY	0x80000	/* gup_fast: prevent fall-back to slow gup */
-#define FOLL_PCI_P2PDMA	0x100000 /* allow returning PCI P2PDMA pages */
-#define FOLL_INTERRUPTIBLE  0x200000 /* allow interrupts from generic signals */
+#define FOLL_TRIED	0x200	/* a retry, previous pass started an IO */
+#define FOLL_REMOTE	0x400	/* we are working on non-current tsk/mm */
+#define FOLL_ANON	0x800	/* don't do file mappings */
+#define FOLL_LONGTERM	0x1000	/* mapping lifetime is indefinite: see below */
+#define FOLL_SPLIT_PMD	0x2000	/* split huge pmd before returning */
+#define FOLL_FAST_ONLY	0x4000	/* gup_fast: prevent fall-back to slow gup */
+#define FOLL_PCI_P2PDMA	0x8000 /* allow returning PCI P2PDMA pages */
+#define FOLL_INTERRUPTIBLE  0x10000 /* allow interrupts from generic signals */
 
 /*
+ * Note that FOLL_PIN is sorted to bit 0 to be coincident with BIO_PAGE_PINNED.
+ *
  * FOLL_PIN and FOLL_LONGTERM may be used in various combinations with each
  * other. Here is what they mean, and how to use them:
  *


  parent reply	other threads:[~2023-01-23 17:33 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 17:29 [PATCH v8 00/10] iov_iter: Improve page extraction (pin or just list) David Howells
2023-01-23 17:29 ` [PATCH v8 01/10] iov_iter: Define flags to qualify page extraction David Howells
2023-01-23 18:20   ` Christoph Hellwig
2023-01-24  2:12   ` John Hubbard
2023-01-23 17:29 ` [PATCH v8 02/10] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-23 18:21   ` Christoph Hellwig
2023-01-24 14:27   ` David Hildenbrand
2023-01-24 14:35   ` David Howells
2023-01-24 14:37     ` David Hildenbrand
2023-01-24 14:45     ` David Howells
2023-01-24 14:52       ` David Hildenbrand
2023-01-23 17:30 ` [PATCH v8 03/10] mm: Provide a helper to drop a pin/ref on a page David Howells
2023-01-23 18:21   ` Christoph Hellwig
2023-01-24  3:03   ` John Hubbard
2023-01-24 14:28   ` David Hildenbrand
2023-01-24 14:41   ` David Howells
2023-01-24 14:52     ` Christoph Hellwig
2023-01-24 14:53       ` David Hildenbrand
2023-01-24 15:04     ` David Howells
2023-01-23 17:30 ` [PATCH v8 04/10] iomap: don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-01-23 18:22   ` Christoph Hellwig
2023-01-24  2:42   ` John Hubbard
2023-01-24  5:59     ` Christoph Hellwig
2023-01-24  7:03       ` John Hubbard
2023-01-24 14:29   ` David Hildenbrand
2023-01-23 17:30 ` [PATCH v8 05/10] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-01-23 17:30 ` [PATCH v8 06/10] block: Rename BIO_NO_PAGE_REF to BIO_PAGE_REFFED and invert the meaning David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 07/10] block: Switch to pinning pages David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-24 14:32   ` David Hildenbrand
2023-01-24 14:47   ` David Howells
2023-01-24 14:53     ` Christoph Hellwig
2023-01-24 15:03     ` David Howells
2023-01-24 16:44       ` Christoph Hellwig
2023-01-24 16:46         ` David Hildenbrand
2023-01-24 16:59         ` Christoph Hellwig
2023-01-24 18:37         ` David Howells
2023-01-24 18:55           ` Christoph Hellwig
2023-01-24 18:38         ` David Howells
2023-01-23 17:30 ` [PATCH v8 08/10] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-01-23 18:23   ` Christoph Hellwig
2023-01-23 17:30 ` [PATCH v8 09/10] block: convert bio_map_user_iov " David Howells
2023-01-23 18:24   ` Christoph Hellwig
2023-01-23 17:30 ` David Howells [this message]
2023-01-23 18:25   ` [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down Christoph Hellwig
2023-01-24  3:08   ` John Hubbard
2023-01-24  3:11     ` John Hubbard
2023-01-24 13:13       ` Jason Gunthorpe
2023-01-24 13:18         ` Christoph Hellwig
2023-01-24 13:43           ` Jason Gunthorpe
2023-01-24 13:40       ` David Howells
2023-01-24 13:46       ` David Howells
2023-01-24 13:47         ` Jason Gunthorpe
2023-01-24 13:57         ` David Howells
2023-01-24 14:00           ` Jason Gunthorpe
2023-01-24 14:02           ` Christoph Hellwig
2023-01-24 14:11           ` David Howells
2023-01-24 14:14             ` Jason Gunthorpe
2023-01-24 14:27             ` David Howells
2023-01-24 14:31               ` Jason Gunthorpe
2023-01-24 14:59               ` David Howells
2023-01-24 15:06                 ` Jason Gunthorpe
2023-01-24 15:12                 ` David Howells
2023-01-24 14:12           ` David Howells
2023-01-24 14:13             ` Christoph Hellwig
2023-01-24 14:25             ` David Howells
2023-01-24  7:05   ` David Howells
2023-01-24  2:02 ` [PATCH v8 00/10] iov_iter: Improve page extraction (pin or just list) John Hubbard
2023-01-24 12:44 ` David Hildenbrand
2023-01-24 13:16   ` Christoph Hellwig
2023-01-24 13:22     ` David Hildenbrand
2023-01-24 13:32       ` Christoph Hellwig
2023-01-24 13:35         ` David Hildenbrand
2023-01-24 13:44 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123173007.325544-11-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=logang@deltatee.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).