linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Jeff Layton <jlayton@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v11 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing
Date: Thu, 26 Jan 2023 14:16:21 +0000	[thread overview]
Message-ID: <20230126141626.2809643-4-dhowells@redhat.com> (raw)
In-Reply-To: <20230126141626.2809643-1-dhowells@redhat.com>

ZERO_PAGE can't go away, no need to hold an extra reference.

Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
cc: Al Viro <viro@zeniv.linux.org.uk>
cc: David Hildenbrand <david@redhat.com>
cc: linux-fsdevel@vger.kernel.org
---
 fs/iomap/direct-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index 9804714b1751..47db4ead1e74 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio,
 	bio->bi_private = dio;
 	bio->bi_end_io = iomap_dio_bio_end_io;
 
-	get_page(page);
+	bio_set_flag(bio, BIO_NO_PAGE_REF);
 	__bio_add_page(bio, page, len, 0);
 	iomap_dio_submit_bio(iter, dio, bio, pos);
 }


  parent reply	other threads:[~2023-01-26 14:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 14:16 [PATCH v11 0/8] iov_iter: Improve page extraction (pin or just list) David Howells
2023-01-26 14:16 ` [PATCH v11 1/8] iov_iter: Define flags to qualify page extraction David Howells
2023-01-26 21:54   ` Al Viro
2023-01-26 23:45     ` David Hildenbrand
2023-01-26 14:16 ` [PATCH v11 2/8] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-26 21:59   ` Al Viro
2023-01-26 22:36     ` Al Viro
2023-01-26 22:49       ` John Hubbard
2023-01-26 23:44       ` David Hildenbrand
2023-01-27  2:02         ` Al Viro
2023-01-27 12:30           ` Jan Kara
2023-01-27 12:34             ` David Hildenbrand
2023-01-26 23:56       ` David Howells
2023-01-27  0:10         ` David Hildenbrand
2023-01-27  0:52         ` Al Viro
2023-01-27  1:21           ` Al Viro
2023-01-27 12:38           ` Jan Kara
2023-01-26 14:16 ` David Howells [this message]
2023-01-26 15:12   ` [PATCH v11 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Christoph Hellwig
2023-01-26 14:16 ` [PATCH v11 4/8] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-01-26 14:16 ` [PATCH v11 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-01-26 14:16 ` [PATCH v11 6/8] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-01-26 14:16 ` [PATCH v11 7/8] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-01-26 14:16 ` [PATCH v11 8/8] block: convert bio_map_user_iov " David Howells
2023-01-30  7:41 ` [PATCH v11 0/8] iov_iter: Improve page extraction (pin or just list) Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126141626.2809643-4-dhowells@redhat.com \
    --to=dhowells@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=david@redhat.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jgg@nvidia.com \
    --cc=jhubbard@nvidia.com \
    --cc=jlayton@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=logang@deltatee.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).