From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD1DC54EED for ; Mon, 30 Jan 2023 06:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235638AbjA3Gij (ORCPT ); Mon, 30 Jan 2023 01:38:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230335AbjA3Gig (ORCPT ); Mon, 30 Jan 2023 01:38:36 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95BBE1ADE6 for ; Sun, 29 Jan 2023 22:38:10 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 8EFCB68BEB; Mon, 30 Jan 2023 07:38:07 +0100 (CET) Date: Mon, 30 Jan 2023 07:38:06 +0100 From: Christoph Hellwig To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Al Viro , Seth Forshee Subject: Re: [PATCH 04/12] fs: drop unused posix acl handlers Message-ID: <20230130063806.GE31145@lst.de> References: <20230125-fs-acl-remove-generic-xattr-handlers-v1-0-6cf155b492b6@kernel.org> <20230125-fs-acl-remove-generic-xattr-handlers-v1-4-6cf155b492b6@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125-fs-acl-remove-generic-xattr-handlers-v1-4-6cf155b492b6@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jan 25, 2023 at 12:28:49PM +0100, Christian Brauner wrote: > Remove struct posix_acl_{access,default}_handler for all filesystems > that don't depend on the xattr handler in their inode->i_op->listxattr() > method in any way. There's nothing more to do than to simply remove the > handler. It's been effectively unused ever since we introduced the new > posix acl api. Looks good: Reviewed-by: Christoph Hellwig