From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A11BC64EC4 for ; Tue, 31 Jan 2023 15:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233243AbjAaPVN (ORCPT ); Tue, 31 Jan 2023 10:21:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233203AbjAaPUn (ORCPT ); Tue, 31 Jan 2023 10:20:43 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 797B613D64; Tue, 31 Jan 2023 07:18:36 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 6D2F168BEB; Tue, 31 Jan 2023 16:18:32 +0100 (CET) Date: Tue, 31 Jan 2023 16:18:32 +0100 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Al Viro , Seth Forshee , Jeff Mahoney , reiserfs-devel@vger.kernel.org Subject: Re: [PATCH v2 1/8] fs: don't use IOP_XATTR for posix acls Message-ID: <20230131151832.GA30960@lst.de> References: <20230125-fs-acl-remove-generic-xattr-handlers-v2-0-214cfb88bb56@kernel.org> <20230125-fs-acl-remove-generic-xattr-handlers-v2-1-214cfb88bb56@kernel.org> <20230130165053.GA8357@lst.de> <20230130180902.mo6vfudled25met4@wittgenstein> <20230131113642.4ivzuxvnfrfjbmhk@wittgenstein> <20230131145501.cscah5qujqh4e36k@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131145501.cscah5qujqh4e36k@wittgenstein> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Sorry for not keeping up with your flow of ideas, so chiming in now: > diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c > index c7d1fa526dea..e293eaaed185 100644 > --- a/fs/reiserfs/inode.c > +++ b/fs/reiserfs/inode.c > @@ -2090,6 +2090,7 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th, > if (IS_PRIVATE(dir) || dentry == REISERFS_SB(sb)->priv_root) { > inode->i_flags |= S_PRIVATE; > inode->i_opflags &= ~IOP_XATTR; > + inode->i_op = &reiserfs_privdir_inode_operations; I wonder if there is any way to set this where reiserfs assigns the other ops. > +const struct inode_operations reiserfs_privdir_inode_operations = { > + .create = reiserfs_create, > + .lookup = reiserfs_lookup, > + .link = reiserfs_link, > + .unlink = reiserfs_unlink, > + .symlink = reiserfs_symlink, > + .mkdir = reiserfs_mkdir, > + .rmdir = reiserfs_rmdir, > + .mknod = reiserfs_mknod, > + .rename = reiserfs_rename, > + .setattr = reiserfs_setattr, > + .permission = reiserfs_permission, > + .fileattr_get = reiserfs_fileattr_get, > + .fileattr_set = reiserfs_fileattr_set, > +}; I suspect many other ops aren't need either, but I really need input from people that known reiserfs better. > + if (likely(!is_bad_inode(inode))) > error = set_posix_acl(mnt_userns, dentry, acl_type, kacl); > else > + error = -EIO; I wonder if the is_bad_inode check should simplify move into get/set_posix_acl. But otherwise this patch looks good.