* [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi
@ 2023-02-08 1:17 Li zeming
2023-02-17 14:41 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-02-08 1:17 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Li zeming
wakeup_bdi does not need to be initialized. It is used after being
assigned.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 6fba5a52127b..2d3191d9c736 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
*/
if (!was_dirty) {
struct list_head *dirty_list;
- bool wakeup_bdi = false;
+ bool wakeup_bdi;
inode->dirtied_when = jiffies;
if (dirtytime)
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi
2023-02-08 1:17 [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi Li zeming
@ 2023-02-17 14:41 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2023-02-17 14:41 UTC (permalink / raw)
To: Li zeming; +Cc: viro, linux-fsdevel, linux-kernel
On Wed 08-02-23 09:17:42, Li zeming wrote:
> wakeup_bdi does not need to be initialized. It is used after being
> assigned.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 6fba5a52127b..2d3191d9c736 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
> */
> if (!was_dirty) {
> struct list_head *dirty_list;
> - bool wakeup_bdi = false;
> + bool wakeup_bdi;
>
> inode->dirtied_when = jiffies;
> if (dirtytime)
> --
> 2.18.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 1:17 [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi Li zeming
2023-02-17 14:41 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).