From: Jan Kara <jack@suse.cz>
To: Li zeming <zeming@nfschina.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi
Date: Fri, 17 Feb 2023 15:41:43 +0100 [thread overview]
Message-ID: <20230217144143.wikkdw44jkdcgdm2@quack3> (raw)
In-Reply-To: <20230208011742.5183-1-zeming@nfschina.com>
On Wed 08-02-23 09:17:42, Li zeming wrote:
> wakeup_bdi does not need to be initialized. It is used after being
> assigned.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 6fba5a52127b..2d3191d9c736 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
> */
> if (!was_dirty) {
> struct list_head *dirty_list;
> - bool wakeup_bdi = false;
> + bool wakeup_bdi;
>
> inode->dirtied_when = jiffies;
> if (dirtytime)
> --
> 2.18.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-02-17 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 1:17 [PATCH] fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi Li zeming
2023-02-17 14:41 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217144143.wikkdw44jkdcgdm2@quack3 \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).