* [PATCH 24/27] kbuild, binfmt_elf: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
@ 2023-02-22 12:14 ` Nick Alcock
0 siblings, 0 replies; only message in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Alexander Viro,
linux-fsdevel, linux-mm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org
---
fs/binfmt_elf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 9a780fafc539..40e87c0eaf15 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -2169,7 +2169,6 @@ static void __exit exit_elf_binfmt(void)
core_initcall(init_elf_binfmt);
module_exit(exit_elf_binfmt);
-MODULE_LICENSE("GPL");
#ifdef CONFIG_BINFMT_ELF_KUNIT_TEST
#include "binfmt_elf_test.c"
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-22 14:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 24/27] kbuild, binfmt_elf: remove MODULE_LICENSE in non-modules Nick Alcock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).