From: Amir Goldstein <amir73il@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 6.1 0/5] Backport v6.2 SGID fixes to LTS 6.1
Date: Thu, 23 Feb 2023 17:20:39 +0200 [thread overview]
Message-ID: <20230223152044.1064909-1-amir73il@gmail.com> (raw)
Greg,
Following are backports of Christian's SGID fixes that were merged to
v6.2-rc1.
Note that Christain's PR [1] contains also two ovl patches (from me).
Those two are independent fixes that have already been AUTOSELected
to 6.1.y.
Christain's fixes also contain a user observable change of behavior
to fix inconsistencies of behavior between chmod/chown and write.
This change is best described in Christain's commit to fix the expected
behavior in xfstests [2].
It is hoped that no applications rely on this minor behavioral
difference, and if we are wrong, we may need to party revert the
change, but in any case, we prefer the behavior of LTS kernels to be
consitent with that of upstream.
I ran the relevant fstests test groups on xfs and on overlayfs over xfs.
I also have backports that I prepared for 5.15 and 5.10, but those
backports include also xfs SGID fixes, so those need to go through the
xfs stable review process.
Thanks,
Amir.
[1] https://lore.kernel.org/linux-fsdevel/20221212112053.99208-1-brauner@kernel.org/
[2] https://lore.kernel.org/linux-fsdevel/20230103-fstests-setgid-v6-2-v3-1-5950c139bfcc@kernel.org/
Christian Brauner (5):
attr: add in_group_or_capable()
fs: move should_remove_suid()
attr: add setattr_should_drop_sgid()
attr: use consistent sgid stripping checks
fs: use consistent setgid checks in is_sxid()
Documentation/trace/ftrace.rst | 2 +-
fs/attr.c | 74 +++++++++++++++++++++++++++++++---
fs/fuse/file.c | 2 +-
fs/inode.c | 64 +++++++++++++----------------
fs/internal.h | 10 ++++-
fs/ocfs2/file.c | 4 +-
fs/open.c | 8 ++--
include/linux/fs.h | 4 +-
8 files changed, 115 insertions(+), 53 deletions(-)
--
2.34.1
next reply other threads:[~2023-02-23 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 15:20 Amir Goldstein [this message]
2023-02-23 15:20 ` [PATCH 6.1 1/5] attr: add in_group_or_capable() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 2/5] fs: move should_remove_suid() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 3/5] attr: add setattr_should_drop_sgid() Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 4/5] attr: use consistent sgid stripping checks Amir Goldstein
2023-02-23 15:20 ` [PATCH 6.1 5/5] fs: use consistent setgid checks in is_sxid() Amir Goldstein
2023-02-28 18:44 ` [PATCH 6.1 0/5] Backport v6.2 SGID fixes to LTS 6.1 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223152044.1064909-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).