* [PATCH] xfs: simplify two-level sysctl registration for xfs_table
@ 2023-03-10 23:02 Luis Chamberlain
2023-03-12 23:31 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Luis Chamberlain @ 2023-03-10 23:02 UTC (permalink / raw)
To: djwong
Cc: linux-xfs, keescook, yzaikin, j.granados, patches, linux-fsdevel,
netdev, linux-kernel, Luis Chamberlain
There is no need to declare two tables to just create directories,
this can be easily be done with a prefix path with register_sysctl().
Simplify this registration.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
This is not clear to some so I've updated the docs for the sysctl
registration here:
https://lore.kernel.org/all/20230310223947.3917711-1-mcgrof@kernel.org/T/#u
fs/xfs/xfs_sysctl.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c
index 546a6cd96729..fade33735393 100644
--- a/fs/xfs/xfs_sysctl.c
+++ b/fs/xfs/xfs_sysctl.c
@@ -210,28 +210,10 @@ static struct ctl_table xfs_table[] = {
{}
};
-static struct ctl_table xfs_dir_table[] = {
- {
- .procname = "xfs",
- .mode = 0555,
- .child = xfs_table
- },
- {}
-};
-
-static struct ctl_table xfs_root_table[] = {
- {
- .procname = "fs",
- .mode = 0555,
- .child = xfs_dir_table
- },
- {}
-};
-
int
xfs_sysctl_register(void)
{
- xfs_table_header = register_sysctl_table(xfs_root_table);
+ xfs_table_header = register_sysctl("fs/xfs", xfs_table);
if (!xfs_table_header)
return -ENOMEM;
return 0;
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: simplify two-level sysctl registration for xfs_table
2023-03-10 23:02 [PATCH] xfs: simplify two-level sysctl registration for xfs_table Luis Chamberlain
@ 2023-03-12 23:31 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2023-03-12 23:31 UTC (permalink / raw)
To: Luis Chamberlain
Cc: djwong, linux-xfs, keescook, yzaikin, j.granados, patches,
linux-fsdevel, netdev, linux-kernel
On Fri, Mar 10, 2023 at 03:02:19PM -0800, Luis Chamberlain wrote:
> There is no need to declare two tables to just create directories,
> this can be easily be done with a prefix path with register_sysctl().
>
> Simplify this registration.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>
> This is not clear to some so I've updated the docs for the sysctl
> registration here:
>
> https://lore.kernel.org/all/20230310223947.3917711-1-mcgrof@kernel.org/T/#u
>
> fs/xfs/xfs_sysctl.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-12 23:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 23:02 [PATCH] xfs: simplify two-level sysctl registration for xfs_table Luis Chamberlain
2023-03-12 23:31 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).