linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: dhowells@redhat.com, linux-cachefs@redhat.com, jack@suse.com,
	jaharkes@cs.cmu.edu, coda@cs.cmu.edu, codalist@coda.cs.cmu.edu,
	anton@tuxera.com, linux-ntfs-dev@lists.sourceforge.net
Cc: ebiederm@xmission.com, keescook@chromium.org, yzaikin@google.com,
	j.granados@samsung.com, patches@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 2/5] devpts: simplify two-level sysctl registration for pty_kern_table
Date: Fri, 10 Mar 2023 15:12:03 -0800	[thread overview]
Message-ID: <20230310231206.3952808-3-mcgrof@kernel.org> (raw)
In-Reply-To: <20230310231206.3952808-1-mcgrof@kernel.org>

There is no need to declare two tables to just create directories,
this can be easily be done with a prefix path with register_sysctl().

Simplify this registration.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 fs/devpts/inode.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 4f25015aa534..fe3db0eda8e4 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -72,24 +72,6 @@ static struct ctl_table pty_table[] = {
 	{}
 };
 
-static struct ctl_table pty_kern_table[] = {
-	{
-		.procname	= "pty",
-		.mode		= 0555,
-		.child		= pty_table,
-	},
-	{}
-};
-
-static struct ctl_table pty_root_table[] = {
-	{
-		.procname	= "kernel",
-		.mode		= 0555,
-		.child		= pty_kern_table,
-	},
-	{}
-};
-
 struct pts_mount_opts {
 	int setuid;
 	int setgid;
@@ -630,7 +612,7 @@ static int __init init_devpts_fs(void)
 {
 	int err = register_filesystem(&devpts_fs_type);
 	if (!err) {
-		register_sysctl_table(pty_root_table);
+		register_sysctl("kernel/pty", pty_table);
 	}
 	return err;
 }
-- 
2.39.1


  parent reply	other threads:[~2023-03-10 23:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 23:12 [PATCH 0/5] misc filesystems: simplify sysctl registration Luis Chamberlain
2023-03-10 23:12 ` [PATCH 1/5] fs/cachefiles: simplify one-level sysctl registration for cachefiles_sysctls Luis Chamberlain
2023-03-10 23:12 ` Luis Chamberlain [this message]
2023-03-13 11:38   ` [PATCH 2/5] devpts: simplify two-level sysctl registration for pty_kern_table Christian Brauner
2023-03-10 23:12 ` [PATCH 3/5] quota: simplify two-level sysctl registration for fs_dqstats_table Luis Chamberlain
2023-03-13 10:32   ` Jan Kara
2023-03-10 23:12 ` [PATCH 4/5] coda: simplify one-level sysctl registration for coda_table Luis Chamberlain
2023-03-13 13:21   ` Jan Harkes
2023-03-10 23:12 ` [PATCH 5/5] ntfs: simplfy one-level sysctl registration for ntfs_sysctls Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230310231206.3952808-3-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=anton@tuxera.com \
    --cc=coda@cs.cmu.edu \
    --cc=codalist@coda.cs.cmu.edu \
    --cc=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=j.granados@samsung.com \
    --cc=jack@suse.com \
    --cc=jaharkes@cs.cmu.edu \
    --cc=keescook@chromium.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=patches@lists.linux.dev \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).