From: Anh Tuan Phan <tuananhlfc@gmail.com>
To: sforshee@kernel.org
Cc: brauner@kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org, shuah@kernel.org,
tuananhlfc@gmail.com
Subject: [PATCH v2 1/1] selftests mount: Fix mount_setattr_test builds failed
Date: Fri, 24 Mar 2023 09:14:15 +0700 [thread overview]
Message-ID: <20230324021415.17416-1-tuananhlfc@gmail.com> (raw)
In-Reply-To: <ZByVac3GsD7RFuaj@do-x1extreme>
When compiling selftests with target mount_setattr I encountered some errors with the below messages:
mount_setattr_test.c: In function ‘mount_setattr_thread’:
mount_setattr_test.c:343:16: error: variable ‘attr’ has initializer but incomplete type
343 | struct mount_attr attr = {
| ^~~~~~~~~~
These errors might be because of linux/mount.h is not included. This patch resolves that issue.
Signed-off-by: Anh Tuan Phan <tuananhlfc@gmail.com>
---
Thanks for replying so quickly, this is my first patch to the kernel. I
changed the include to use angle bracket as your suggestion.
tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
index 582669ca38e9..c6a8c732b802 100644
--- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
+++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
@@ -18,6 +18,7 @@
#include <grp.h>
#include <stdbool.h>
#include <stdarg.h>
+#include <linux/mount.h>
#include "../kselftest_harness.h"
--
2.34.1
next prev parent reply other threads:[~2023-03-24 2:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 17:28 [PATCH v1] selftests mount: Fix mount_setattr_test builds failed Anh Tuan Phan
2023-03-23 18:07 ` Seth Forshee
2023-03-24 2:14 ` Anh Tuan Phan [this message]
2023-03-27 8:00 ` [PATCH v2 1/1] " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324021415.17416-1-tuananhlfc@gmail.com \
--to=tuananhlfc@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=sforshee@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).