From: Andrew Morton <akpm@linux-foundation.org>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: Matthew Wilcox <willy@infradead.org>,
<linux-fsdevel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<dan.j.williams@intel.com>, <jack@suse.cz>, <djwong@kernel.org>
Subject: Re: [PATCH] fsdax: unshare: zero destination if srcmap is HOLE or UNWRITTEN
Date: Fri, 24 Mar 2023 13:44:34 -0700 [thread overview]
Message-ID: <20230324134434.9f005404a90cb44bdb9a8c49@linux-foundation.org> (raw)
In-Reply-To: <cf8419ae-e1ce-ee8b-6346-3bcb49f59cc2@fujitsu.com>
On Fri, 24 Mar 2023 12:28:07 +0800 Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote:
> > ie it's the data that was in whatever file happened to use that space
> > last, so this is a security bug because it's a data leak, and a backport
> > is needed, and you should have indicated that by putting a cc: stable
> > tag on the patch?
>
> Yes, cc stable is needed. Then should I send a new patch with the tag
> added?
Thanks. I updated the changelog and added cc:stable.
: unshare copies data from source to destination. But if the source is
: HOLE or UNWRITTEN extents, we should zero the destination, otherwise
: the HOLE or UNWRITTEN part will be user-visible old data of the new
: allocated extent because it wasn't cleared.
:
: Found by running generic/649 while mounting with -o dax=always on pmem.
prev parent reply other threads:[~2023-03-24 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:11 [PATCH] fsdax: unshare: zero destination if srcmap is HOLE or UNWRITTEN Shiyang Ruan
2023-03-22 23:03 ` Andrew Morton
2023-03-23 6:50 ` Shiyang Ruan
2023-03-23 14:59 ` Darrick J. Wong
2023-03-23 22:11 ` Andrew Morton
2023-03-24 1:50 ` Shiyang Ruan
2023-03-24 3:33 ` Matthew Wilcox
2023-03-24 3:42 ` Shiyang Ruan
2023-03-24 4:17 ` Matthew Wilcox
2023-03-24 4:28 ` Shiyang Ruan
2023-03-24 20:44 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324134434.9f005404a90cb44bdb9a8c49@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).