From: Al Viro <viro@zeniv.linux.org.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org,
brauner@kernel.org
Subject: Re: [PATCHSET 0/2] Turn single segment imports into ITER_UBUF
Date: Mon, 27 Mar 2023 21:02:26 +0100 [thread overview]
Message-ID: <20230327200226.GI3390869@ZenIV> (raw)
In-Reply-To: <c975dbcf-1332-5bb5-3375-04280407a897@kernel.dk>
On Mon, Mar 27, 2023 at 12:59:09PM -0600, Jens Axboe wrote:
> > That's a great idea. Two questions - do we want to make that
> > WARN_ON_ONCE()? And then do we want to include a WARN_ON_ONCE for a
> > non-supported type? Doesn't seem like high risk as they've all been used
> > with ITER_IOVEC until now, though.
>
> Scratch that last one, user_backed should double as that as well. At
> least currently, where ITER_UBUF and ITER_IOVEC are the only two
> iterators that hold user backed memory.
Quite. As for the WARN_ON_ONCE vs. WARN_ON... No preferences, really.
next prev parent reply other threads:[~2023-03-27 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 20:44 [PATCHSET 0/2] Turn single segment imports into ITER_UBUF Jens Axboe
2023-03-24 20:44 ` [PATCH 1/2] iov_iter: convert import_single_range() to ITER_UBUF Jens Axboe
2023-03-24 20:44 ` [PATCH 2/2] iov_iter: import single vector iovecs as ITER_UBUF Jens Axboe
2023-03-24 21:14 ` [PATCHSET 0/2] Turn single segment imports into ITER_UBUF Linus Torvalds
2023-03-24 21:52 ` Jens Axboe
2023-03-25 4:46 ` Al Viro
2023-03-27 18:01 ` Jens Axboe
2023-03-27 18:42 ` Al Viro
2023-03-27 18:52 ` Jens Axboe
2023-03-27 18:59 ` Jens Axboe
2023-03-27 20:02 ` Al Viro [this message]
2023-03-27 20:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327200226.GI3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).