From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org
Cc: torvalds@linux-foundation.org, brauner@kernel.org,
viro@zeniv.linux.org.uk, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 6/8] IB/qib: make qib_write_iter() deal with ITER_UBUF iov_iter
Date: Tue, 28 Mar 2023 11:36:11 -0600 [thread overview]
Message-ID: <20230328173613.555192-7-axboe@kernel.dk> (raw)
In-Reply-To: <20230328173613.555192-1-axboe@kernel.dk>
Don't assume that a user backed iterator is always of the type
ITER_IOVEC. Handle the single segment case separately, then we can
use the same logic for ITER_UBUF and ITER_IOVEC.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
drivers/infiniband/hw/qib/qib_file_ops.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c
index 80fe92a21f96..577d972ba048 100644
--- a/drivers/infiniband/hw/qib/qib_file_ops.c
+++ b/drivers/infiniband/hw/qib/qib_file_ops.c
@@ -2244,10 +2244,18 @@ static ssize_t qib_write_iter(struct kiocb *iocb, struct iov_iter *from)
struct qib_filedata *fp = iocb->ki_filp->private_data;
struct qib_ctxtdata *rcd = ctxt_fp(iocb->ki_filp);
struct qib_user_sdma_queue *pq = fp->pq;
+ int nr_segs = iovec_nr_user_vecs(from);
- if (!iter_is_iovec(from) || !from->nr_segs || !pq)
+ if (!from->user_backed)
+ return -EFAULT;
+ if (!nr_segs || !pq)
return -EINVAL;
+ if (nr_segs == 1) {
+ struct iovec iov = iov_iter_iovec(from);
+ return qib_user_sdma_writev(rcd, pq, &iov, 1);
+ }
+
return qib_user_sdma_writev(rcd, pq, from->iov, from->nr_segs);
}
--
2.39.2
next prev parent reply other threads:[~2023-03-28 17:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 17:36 [PATCHSET v4 0/8] Turn single segment imports into ITER_UBUF Jens Axboe
2023-03-28 17:36 ` [PATCH 1/8] iov_iter: teach iov_iter_iovec() to deal with ITER_UBUF Jens Axboe
2023-03-28 17:36 ` [PATCH 2/8] iov_iter: add iovec_nr_user_vecs() helper Jens Axboe
2023-03-28 18:42 ` Al Viro
2023-03-28 18:45 ` Linus Torvalds
2023-03-28 19:27 ` Jens Axboe
2023-03-28 17:36 ` [PATCH 3/8] snd: move mapping an iov_iter to user bufs into a helper Jens Axboe
2023-03-28 17:36 ` [PATCH 4/8] snd: make snd_map_bufs() deal with ITER_UBUF Jens Axboe
2023-03-28 17:50 ` Linus Torvalds
2023-03-28 17:52 ` Jens Axboe
2023-03-28 18:52 ` Al Viro
2023-03-28 19:28 ` Jens Axboe
2023-03-28 17:36 ` [PATCH 5/8] IB/hfi1: make hfi1_write_iter() deal with ITER_UBUF iov_iter Jens Axboe
2023-03-28 18:43 ` Linus Torvalds
2023-03-28 18:55 ` Matthew Wilcox
2023-03-28 19:05 ` Linus Torvalds
2023-03-28 19:16 ` Linus Torvalds
2023-03-28 21:21 ` Jens Axboe
2023-03-28 21:38 ` Jens Axboe
2023-03-28 21:51 ` Jens Axboe
2023-03-28 19:30 ` Jens Axboe
2023-03-28 20:38 ` Al Viro
2023-03-28 20:46 ` Jens Axboe
2023-03-28 22:06 ` Linus Torvalds
2023-03-28 17:36 ` Jens Axboe [this message]
2023-03-28 17:36 ` [PATCH 7/8] iov_iter: convert import_single_range() to ITER_UBUF Jens Axboe
2023-03-28 17:36 ` [PATCH 8/8] iov_iter: import single vector iovecs as ITER_UBUF Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328173613.555192-7-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).