* [PATCH] fs: vboxsf: remove unused out_len variable
@ 2023-03-29 23:03 Tom Rix
2023-03-30 8:19 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-29 23:03 UTC (permalink / raw)
To: hdegoede, nathan, ndesaulniers; +Cc: linux-fsdevel, linux-kernel, llvm, Tom Rix
clang with W=1 reports
fs/vboxsf/utils.c:442:9: error: variable
'out_len' set but not used [-Werror,-Wunused-but-set-variable]
size_t out_len;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/vboxsf/utils.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
index dd0ae1188e87..ab0c9b01a0c2 100644
--- a/fs/vboxsf/utils.c
+++ b/fs/vboxsf/utils.c
@@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
{
const char *in;
char *out;
- size_t out_len;
size_t out_bound_len;
size_t in_bound_len;
@@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
in_bound_len = utf8_len;
out = name;
- out_len = 0;
/* Reserve space for terminating 0 */
out_bound_len = name_bound_len - 1;
@@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
out += nb;
out_bound_len -= nb;
- out_len += nb;
}
*out = 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs: vboxsf: remove unused out_len variable
2023-03-29 23:03 [PATCH] fs: vboxsf: remove unused out_len variable Tom Rix
@ 2023-03-30 8:19 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2023-03-30 8:19 UTC (permalink / raw)
To: Tom Rix, nathan, ndesaulniers; +Cc: linux-fsdevel, linux-kernel, llvm
Hi,
On 3/30/23 01:03, Tom Rix wrote:
> clang with W=1 reports
> fs/vboxsf/utils.c:442:9: error: variable
> 'out_len' set but not used [-Werror,-Wunused-but-set-variable]
> size_t out_len;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> fs/vboxsf/utils.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
> index dd0ae1188e87..ab0c9b01a0c2 100644
> --- a/fs/vboxsf/utils.c
> +++ b/fs/vboxsf/utils.c
> @@ -439,7 +439,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> {
> const char *in;
> char *out;
> - size_t out_len;
> size_t out_bound_len;
> size_t in_bound_len;
>
> @@ -447,7 +446,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> in_bound_len = utf8_len;
>
> out = name;
> - out_len = 0;
> /* Reserve space for terminating 0 */
> out_bound_len = name_bound_len - 1;
>
> @@ -468,7 +466,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
>
> out += nb;
> out_bound_len -= nb;
> - out_len += nb;
> }
>
> *out = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-30 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-29 23:03 [PATCH] fs: vboxsf: remove unused out_len variable Tom Rix
2023-03-30 8:19 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).