From: Christoph Hellwig <hch@lst.de>
To: Jeff Layton <jlayton@kernel.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tejun Heo <tj@kernel.org>, Chuck Lever <chuck.lever@oracle.com>,
Phillip Potter <phil@philpotter.co.uk>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: consolidate dt_type() helper definitions
Date: Thu, 30 Mar 2023 02:03:40 +0200 [thread overview]
Message-ID: <20230330000340.GA2189@lst.de> (raw)
In-Reply-To: <20230330000157.297698-1-jlayton@kernel.org>
> - v9fs_qid2ino(&st.qid), dt_type(&st));
> + v9fs_qid2ino(&st.qid), v9fs_dt_type(&st));
This adds an overly long line. Also renaming the v9fs dt_type seems
like it should be a prep patch.
> +/* Relationship between i_mode and the DT_xxx types */
This comment seems a bit terse.
> +static inline unsigned char dt_type(umode_t mode)
> +{
> + return ((mode) & S_IFMT) >> S_DT_SHIFT;
No need for the inner braces.
next prev parent reply other threads:[~2023-03-30 0:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 0:01 [PATCH v2] fs: consolidate dt_type() helper definitions Jeff Layton
2023-03-30 0:03 ` Christoph Hellwig [this message]
2023-03-30 5:14 ` Christian Brauner
2023-03-30 5:44 ` Christian Brauner
2023-03-30 10:14 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330000340.GA2189@lst.de \
--to=hch@lst.de \
--cc=asmadeus@codewreck.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=phil@philpotter.co.uk \
--cc=tj@kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).