From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Punit Agrawal <punit.agrawal@bytedance.com>
Subject: [PATCH 6/6] mm: Run the fault-around code under the VMA lock
Date: Tue, 4 Apr 2023 14:58:50 +0100 [thread overview]
Message-ID: <20230404135850.3673404-7-willy@infradead.org> (raw)
In-Reply-To: <20230404135850.3673404-1-willy@infradead.org>
The map_pages fs method should be safe to run under the VMA lock instead
of the mmap lock. This should have a measurable reduction in contention
on the mmap lock.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 9952bebd25b4..590ccaf6f7fb 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -4521,8 +4521,6 @@ static vm_fault_t do_read_fault(struct vm_fault *vmf)
{
vm_fault_t ret = 0;
- if (vmf->flags & FAULT_FLAG_VMA_LOCK)
- return VM_FAULT_RETRY;
/*
* Let's call ->map_pages() first and use ->fault() as fallback
* if page by the offset is not ready to be mapped (cold cache or
@@ -4534,6 +4532,8 @@ static vm_fault_t do_read_fault(struct vm_fault *vmf)
return ret;
}
+ if (vmf->flags & FAULT_FLAG_VMA_LOCK)
+ return VM_FAULT_RETRY;
ret = __do_fault(vmf);
if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE | VM_FAULT_RETRY)))
return ret;
--
2.39.2
next prev parent reply other threads:[~2023-04-04 14:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 13:58 [PATCH 0/6] Avoid the mmap lock for fault-around Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 1/6] mm: Allow per-VMA locks on file-backed VMAs Matthew Wilcox (Oracle)
2023-04-07 17:54 ` Suren Baghdasaryan
2023-04-07 20:12 ` Matthew Wilcox
2023-04-07 20:26 ` Suren Baghdasaryan
2023-04-07 21:36 ` Matthew Wilcox
2023-04-07 22:40 ` Suren Baghdasaryan
2023-04-07 22:49 ` Suren Baghdasaryan
2023-04-14 18:02 ` Suren Baghdasaryan
2023-04-04 13:58 ` [PATCH 2/6] mm: Move FAULT_FLAG_VMA_LOCK check from handle_mm_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 3/6] mm: Move FAULT_FLAG_VMA_LOCK check into handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 4/6] mm: Move FAULT_FLAG_VMA_LOCK check down in handle_pte_fault() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` [PATCH 5/6] mm: Move the FAULT_FLAG_VMA_LOCK check down from do_pte_missing() Matthew Wilcox (Oracle)
2023-04-04 13:58 ` Matthew Wilcox (Oracle) [this message]
2023-04-04 15:23 ` [PATCH 6/6] mm: Run the fault-around code under the VMA lock Matthew Wilcox
2023-04-07 18:20 ` Suren Baghdasaryan
2023-04-10 4:53 ` Yin, Fengwei
2023-04-10 14:11 ` Matthew Wilcox
2023-04-12 7:35 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404135850.3673404-7-willy@infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=punit.agrawal@bytedance.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).