From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5184EC77B7F for ; Wed, 3 May 2023 03:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229584AbjECDMP (ORCPT ); Tue, 2 May 2023 23:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjECDMN (ORCPT ); Tue, 2 May 2023 23:12:13 -0400 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A5A7AD; Tue, 2 May 2023 20:12:11 -0700 (PDT) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 342IONAl031824; Wed, 3 May 2023 03:12:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=Y7UMJIMK6A7KLNl6YawEwNFPCYPnSQbxDG+5WYHW338=; b=PB8Kl05nZpfzlIUfk3di8PHZbnzq2h7bJn+K9vxfsFIq+ZYuu6/zTiHTrUzgffkp/j2c 1N2mPcIw3oVMjSmaDdIrCcun/k63ooXHPCRNajcn8qF2CfCpsMrWS2a5PURI8P5UfDB3 q3U9FYUPLdh/pNKNGobu7iKbKTxRsQPxgxTSxWUZYtTtSSVGLML8r9ewP9GofBXVqzTJ s/JGOdSKvAaqHRcEQfbT+B25vsaVrgIWl039H/7bi3aW+8ATFtN6LQCPRslhD/P8W8FK n6XSwBnhdDP+R33dHdjPpmYd/8ySY+2jUBPEm6Rc80TMDdVvyGpm6+OjjLLqUV8Y0xQW TA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q8u4ap59r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 May 2023 03:12:01 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3430JiPC027493; Wed, 3 May 2023 03:12:00 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2045.outbound.protection.outlook.com [104.47.57.45]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3q8spcu0w1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 May 2023 03:11:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SoKSfUXeE48MqYS7kT8pQE8rLdy12a154hkQ2K/q1+nr1RrwqsaanW/93y5UUasyP/+ZFMj46m0sz17VBtDPDCpzbvcQ6L6vNHKt9hAqAeZfBxH6LhI1NYOW3Lc6ZFfaKon91Oer6kyZgiv40b/+DR50il4FQhnskM6oVghE8C9te/eJXbl/z1vytM96c4bBGl2t7Q5U2mFsnW2DPVquDdLKBjlZ/1a3Uh84VZfwhaXnWUYOnK7exp8RRw1xpGe9kOOgypSDgbal5QaoOHw9I+ANZNOHHl763bCVRpRK2YVEX8sfJNgE0ZmxaM0OsEbD6iY9Eoakc1noRpA2MilA4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y7UMJIMK6A7KLNl6YawEwNFPCYPnSQbxDG+5WYHW338=; b=aX13oJq4eTS/VW38BKKjMjWTJf5v7T4Q36H1dI8DSWQQY+M9r9kd+U61yOhSx823I8xXTl7KMdybrrFfS9pTHKV59Edkid8gG9v4bc/FyMyInRv3MJHfMywtn1ynhJ1Zdq22FQ2iiWLbHUsWHi4SElnZoaR3jhdG3pH2vJ2vxNtUZlZGaPWS1Emu956ssTeHF5810IvXoCb3kFVumq+FUJBLvUbFtWvFVyAI5jhOY2lfOMXvSLXY6fM7cW0FW7Cfx0GXMKzGEXtH5AwxY+niMcwbHkVUh4CD7xole9aKJqz+IRKa0wmbZuio4wysm79cf/iYuooNYZzQKKIV9eBWWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y7UMJIMK6A7KLNl6YawEwNFPCYPnSQbxDG+5WYHW338=; b=GcTjmzxHVfTi4pyFgh54H0dsk/jUGaEM20EhJEoAVyJd+7i451gLTM3sc2lcS5fjfdiqqDqsvV0Jo2dlRCqDVUeC6xKq/HMIRnhUDml/rQwLJu6LvFNmQ6/LaausL1R0+dbG8byQTDh3wldvSWRsb6WMd3yt/CVTO8VKRuLJutE= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by MW4PR10MB6345.namprd10.prod.outlook.com (2603:10b6:303:1ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Wed, 3 May 2023 03:11:57 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::ffb:de39:b76b:52eb%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 03:11:57 +0000 Date: Tue, 2 May 2023 20:11:54 -0700 From: Mike Kravetz To: Ackerley Tng Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, willy@infradead.org, sidhartha.kumar@oracle.com, jhubbard@nvidia.com, vannapurve@google.com, erdemaktas@google.com Subject: Re: [PATCH] fs: hugetlbfs: Set vma policy only when needed for allocating folio Message-ID: <20230503031154.GD3873@monkey> References: <20230502235622.3652586-1-ackerleytng@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230502235622.3652586-1-ackerleytng@google.com> X-ClientProxiedBy: MW4PR03CA0230.namprd03.prod.outlook.com (2603:10b6:303:b9::25) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR10MB4196:EE_|MW4PR10MB6345:EE_ X-MS-Office365-Filtering-Correlation-Id: e402d66f-fdf7-48b2-d292-08db4b8427a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fULrcA/HWJTPgBVPwjNX4NQoxwuVWpRJrnCBCH9MYO0hNAUjjvnr98ishq5SK+q9AB9kS2yKTSG/eDI6DpkNiXQb94JNdKcOvxr7NYt4K8o/6qDcjvdRtT5fOui4UhcKjb0nEYJ3XzosF/YF8q1ZBDc0OImD4QMKNXUeBuTk4/XzzvHTFeNuDlCebpt4BxD6Qk332iGrVN6bomyJNSxf5Jakcpu5TQLNdvLxzAl0TlKMYYzvzbyXUn/meYkLKfyPxvth2LD4Jl8mVMMiuLUpbUfXNWmaRFO7VM7WLrKrzPJO35rdJdjJPyJ0cDe4wlGUKMQQdoSHEf2TrQrYldboWqeXM+PsDfgc09HkxB2IFihBQqw+zAHnei/0KVLGEJACkIJ5hfDYGqQ6OGtCJkpdMAHSQFL8i74We3cI1HFHdjbqOLYWDjPL+Mlf5zuPWqXSP7WNxBJJi88+Y7y3C/OW6hg9q11Oxnr+GqOJNSM8BtJ+uWpW93lkbTsCYb30rGZJJ0lVBwxO4OMh+7CLPI0q0RbT00ZPvS/S4X5iFAn00MOzd7CzAdy1z696Duxyyw63 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(7916004)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(316002)(83380400001)(41300700001)(44832011)(6666004)(6486002)(33656002)(9686003)(186003)(6512007)(26005)(1076003)(6506007)(33716001)(53546011)(2906002)(7416002)(5660300002)(38100700002)(4326008)(66556008)(66476007)(6916009)(66946007)(8676002)(8936002)(86362001)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x7/POw3kx70GnHrIqBWsKLGoUJwpLA4MpsKejdC1IaaegOIE+ZPbP4y+6iTI?= =?us-ascii?Q?bGvnbkWN5sdGbQJDafuIZasTGXe8uMTV1K9rS0dgjwFQlv+idc+dl5tbFlzc?= =?us-ascii?Q?fDXhfRG2udM6X2UjBCM2UQyBqrsytc8O9scNyRlxuY1+LHvZQ+1Oq9T8qDQl?= =?us-ascii?Q?WkrvRIMO08zNefX9lqg1sJK9nUDchvLiQrcc4rRwx3YmdvKSuJpPqVNLtIJb?= =?us-ascii?Q?kH0UHAzk+MZIe6+B4qS9Yrh/PIkfqUdFWQQwcug7PbAeerRlEly5r80OONYv?= =?us-ascii?Q?J5N2YZV0ad3yJg7weVLMIR9dAm4CJIpV4D+V1raJks+SeGpmPRA3jJAi4Fp+?= =?us-ascii?Q?KN6nMfUE5mpJPMI8jfCMnlKsxePrdFguJ/LIow5iMoFGrok+WcBQ1Hf5uZ8l?= =?us-ascii?Q?P+VrY+Mq8ppQWrOo7lFKfVU5Q5zUmbfQiEGUj21nlH35+75B3jqebJrhHgss?= =?us-ascii?Q?+xC0bC49yV1xQv8Elmfzgb+yU+r3fdpNNcwc+F3V1IcuJt/hp+bEJa5cBmEF?= =?us-ascii?Q?97gtLcc7DR6Prb3C3spzJMzf/8cKlttZjyy7hQc04T6Z5KnSPAj91xiU+sor?= =?us-ascii?Q?zFHR6DZLyuQ3u/ob8vFmfYXPfpcBBiy2M0vb2X7MqlgfkXnKUrfKE6jJGALF?= =?us-ascii?Q?uJio9LfYfsqg1Y/vf4hEoIfMHB88tON00cEDwy6bid8Z8F6paei+754ihgZg?= =?us-ascii?Q?crdge4j5o55hLiTClQX/5Y3SssT2Bd3GUbFNzrorIjBqVqL+gF1RAXcY4IYb?= =?us-ascii?Q?YzpuYDJ53rQBXIQKb+rin23DK/fMevYxpxhRKhSzoEtzH27HYs8O2uO00d0y?= =?us-ascii?Q?DwQsI+5L/v+ym/sNxJEih/9t6PolDz7JsWWlDrn9A/n7mky9M9il+7IW4P1J?= =?us-ascii?Q?7PLWcolVuggZqiiyixhoLjZy+jOu6YRV6X5UVX99Jcd6Ou9U1gLDzh0CjHdA?= =?us-ascii?Q?UL1u7Ut9SACN9xpn/WMaClxjBoaGwbCZLELcbukYbk58jJSCwdizFMhd3sCl?= =?us-ascii?Q?8nHrFhnF7e64b+1bHSijN/eto4X7G7AjlU5YuUAXmue/BFc8AmiKv5i/HKnj?= =?us-ascii?Q?QhjkQsVT6K7tYxzBNB7QH6kCkv+sea3ecRE0ED2py3wTYcg5liDKlPEoAt1P?= =?us-ascii?Q?WVUVytSplS5nYPVHftMLyCE00qvFiD8w7tRqYLt/PsXfj3JL65vFkPS8Lo1U?= =?us-ascii?Q?F97J1iChYrm4TCv94tDJOlXjcciFpethOqtW+EnvudT1GH/Ueyl9JK4uH27Y?= =?us-ascii?Q?zcMovTmmHzNlJy1S01zCloTG50a2OimtvX3eGrjO6S3EvixvgJqEpF7AzhZH?= =?us-ascii?Q?oC8jdA0AxKZIkRJ3OACpXjKUxoRcxeBaTlquGnqq0Agd0tG3tHMBZ7B65IQX?= =?us-ascii?Q?NiaVmTKmBV/uslqRPngMobwxx3tp4udBdH8UwOMTOesGuSf/kBCY7R+/5Szx?= =?us-ascii?Q?dLBdCZa4/NsL+KFIIHMb+XgJbuXs5otJqEs3xc+PdcJoSM9a31OrRtlkDIu1?= =?us-ascii?Q?VP/Kf9c1kXRg2kZzHKpe2Zd81r7jx4KxB57A1DjKzL6vzFTeUeciE4KIv/FJ?= =?us-ascii?Q?UDg8WHo1r1n7oC/H9JBB/1vgyEKc/Xzp/OamEuqZk4qjLXlDzb5Ty8ZjBm8G?= =?us-ascii?Q?7A=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Oz+8iZJy97S5ZHDVHwhJKOMm/6+hLNlPAwJqDj0lK7ED06XSAm3et0glKYB+?= =?us-ascii?Q?fZrm4OqLN8xBlIc/hAYwdAypayMcUoGfYViP2Dodz/oOueLtFBSV2B2N44Ad?= =?us-ascii?Q?NiYnEaM6LuCXJJbLzoZkhQo7zRqZrHkKB0u7XA4uEFHK8EwJbepwu6DUladD?= =?us-ascii?Q?P8twS6vNRvik3UOrYmIM9EeDINmeM/mPKyqeguNe9KsySqZoMR0FoJphkgWD?= =?us-ascii?Q?TAFRrqIZRnLEd9O0jppPoT/tgvsLQqaUc5MyF3x5/fruKXxBxUYu5LWEBnAw?= =?us-ascii?Q?UM+tnr7pVcXB+rnJ5DTOtfpV1TufXPLZaIKb515XKRD0uY8kTkxzWbh+F8Oz?= =?us-ascii?Q?SQk93k41b0WU77pjThyd4kq2Q7A4bqumJbIFWAOU1/WU5K+enda7UoPXXiBr?= =?us-ascii?Q?ZSYk6+lmBPX6N6NxtS1B1w/6KaGlnixVp4p4hC0q0aJqdYYlZ83kj73rJSDH?= =?us-ascii?Q?McuyoEB1dNfutRHs9kf0RH3s3kRkF1jkCj2WR4hVEkoCu9uGPYe2VcFFjtCT?= =?us-ascii?Q?gIrXyYrGG0IfvapKqaRNdls0EWhb1nvzxvrq0mQo/8nPAhbHBOSOveycwLX3?= =?us-ascii?Q?P+MFK53uPjt+HSSEr8CSPL+4dySvEo6Fd3p+Tkfok1eTWbGQqi0vpwIZokRe?= =?us-ascii?Q?quuQhE+PfrAmbQGAoCjLIRsZb/lSprDMWSKemDUMu8zYV17ABWoHD8asO9cU?= =?us-ascii?Q?5sCE3yhFnJ64S3vHN/s7B/h25FxnlE2hcc8W2mW/FEgUnupHmRsizH1+ntbb?= =?us-ascii?Q?YHtVqJSuntF5CXX6PchMKSnE2JB3AGhibuFX/9C3kOfCIyLW0rx2pQwZ2+St?= =?us-ascii?Q?beRDFTb13jKqwx2X4EIOEIZMYcl+MvVq5qRZb+D2ymwdgwodzNmuWDn9zyj8?= =?us-ascii?Q?jqbDjY6SKTS3m/jSVadvYSdAEkF6ll81u0vUYFKPBhUP3zr8hZXOR4aQ34fO?= =?us-ascii?Q?KqRhscERtzoLxci4ppfgAQ=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e402d66f-fdf7-48b2-d292-08db4b8427a8 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 03:11:57.7504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2xRLnFSmLPFZpISaA4WyU290KcPYVTsTZGC8zi6avbEV/7Y/vZvSzXNzMV+dDSHIVu+ZWPGWgo5Vb+3jC1avLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6345 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-02_14,2023-04-27_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305030025 X-Proofpoint-GUID: YR8LbaitN6l62Wh0Rj-DLsZdzOq4tyUE X-Proofpoint-ORIG-GUID: YR8LbaitN6l62Wh0Rj-DLsZdzOq4tyUE Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 05/02/23 23:56, Ackerley Tng wrote: > Calling hugetlb_set_vma_policy() later avoids setting the vma policy > and then dropping it on a page cache hit. > > Signed-off-by: Ackerley Tng > --- > fs/hugetlbfs/inode.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) I suspect you noticed this when debugging the issue with using page_cache_next_miss. :) Thanks! Reviewed-by: Mike Kravetz -- Mike Kravetz > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index f640cff1bbce..380b1cd6c93f 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -833,9 +833,6 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > break; > } > > - /* Set numa allocation policy based on index */ > - hugetlb_set_vma_policy(&pseudo_vma, inode, index); > - > /* addr is the offset within the file (zero based) */ > addr = index * hpage_size; > > @@ -846,7 +843,6 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > /* See if already present in mapping to avoid alloc/free */ > if (filemap_has_folio(mapping, index)) { > mutex_unlock(&hugetlb_fault_mutex_table[hash]); > - hugetlb_drop_vma_policy(&pseudo_vma); > continue; > } > > @@ -858,6 +854,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > * folios in these areas, we need to consume the reserves > * to keep reservation accounting consistent. > */ > + hugetlb_set_vma_policy(&pseudo_vma, inode, index); > folio = alloc_hugetlb_folio(&pseudo_vma, addr, 0); > hugetlb_drop_vma_policy(&pseudo_vma); > if (IS_ERR(folio)) { > -- > 2.40.1.495.gc816e09b53d-goog >