From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F3EC77B7F for ; Fri, 5 May 2023 18:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233284AbjEESjl (ORCPT ); Fri, 5 May 2023 14:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233254AbjEESjj (ORCPT ); Fri, 5 May 2023 14:39:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3BA1E996; Fri, 5 May 2023 11:39:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 02AC8612A1; Fri, 5 May 2023 18:39:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60143C433D2; Fri, 5 May 2023 18:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683311975; bh=K/Y08sTCTSnRoZgjb16tDaF0uh6/O7C3F9BZfsmlEug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vAI25Pqes2oc/YXzsbgTjpK1lOHAOBZzubxbrrbKnPrxL1srLXYw+IXxxMGi7koMM fT5owlpm4xzf2xtwgMzeHwoFdpd/dZICCv2B2jml8B8BMjVWxogHtAUdpZXL2OeqOH 0VCfBBz102w5H5Act9Zr6zOhurMGPlKnAVW7xrI8DuGm/nEZVA7SSxBmGP3baSFHRQ r5qnAGZGjZD4Pc/7nwE7l9s8HLOjKL1nN0SQuKvJFsvo9WgySG1LQtdIEWkuFuPpKj 6onOPa1+e9YQHzpLg+/8Fq6bYWZ9A5d18EcZWy71jbPLYIFgwZmY2NaG4A8An5nKWv /eP8TF/+lhQqw== Date: Fri, 5 May 2023 11:39:34 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Jens Axboe , Al Viro , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 7/9] fs: add a method to shut down the file system Message-ID: <20230505183934.GH15394@frogsfrogsfrogs> References: <20230505175132.2236632-1-hch@lst.de> <20230505175132.2236632-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505175132.2236632-8-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 05, 2023 at 01:51:30PM -0400, Christoph Hellwig wrote: > Add a new ->shutdown super operation that can be used to tell the file > system to shut down, and call it from newly created holder ops when the > block device under a file system shuts down. > > This only covers the main block device for "simple" file systems using > get_tree_bdev / mount_bdev. File systems their own get_tree method > or opening additional devices will need to set up their own > blk_holder_ops. > > Signed-off-by: Christoph Hellwig Looks good, Reviewed-by: Darrick J. Wong --D > --- > fs/super.c | 21 +++++++++++++++++++-- > include/linux/fs.h | 1 + > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/fs/super.c b/fs/super.c > index 012ce140080375..f127589700ab25 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1206,6 +1206,22 @@ int get_tree_keyed(struct fs_context *fc, > EXPORT_SYMBOL(get_tree_keyed); > > #ifdef CONFIG_BLOCK > +static void fs_mark_dead(struct block_device *bdev) > +{ > + struct super_block *sb; > + > + sb = get_super(bdev); > + if (!sb) > + return; > + > + if (sb->s_op->shutdown) > + sb->s_op->shutdown(sb); > + drop_super(sb); > +} > + > +static const struct blk_holder_ops fs_holder_ops = { > + .mark_dead = fs_mark_dead, > +}; > > static int set_bdev_super(struct super_block *s, void *data) > { > @@ -1248,7 +1264,8 @@ int get_tree_bdev(struct fs_context *fc, > if (!fc->source) > return invalf(fc, "No source specified"); > > - bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, NULL); > + bdev = blkdev_get_by_path(fc->source, mode, fc->fs_type, > + &fs_holder_ops); > if (IS_ERR(bdev)) { > errorf(fc, "%s: Can't open blockdev", fc->source); > return PTR_ERR(bdev); > @@ -1333,7 +1350,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type, > if (!(flags & SB_RDONLY)) > mode |= FMODE_WRITE; > > - bdev = blkdev_get_by_path(dev_name, mode, fs_type, NULL); > + bdev = blkdev_get_by_path(dev_name, mode, fs_type, &fs_holder_ops); > if (IS_ERR(bdev)) > return ERR_CAST(bdev); > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 21a98168085641..cf3042641b9b30 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1932,6 +1932,7 @@ struct super_operations { struct shrink_control *); > long (*free_cached_objects)(struct super_block *, > struct shrink_control *); > + void (*shutdown)(struct super_block *sb); > }; > > /* > -- > 2.39.2 >