From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA13C7EE2F for ; Mon, 8 May 2023 13:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234183AbjEHNBu (ORCPT ); Mon, 8 May 2023 09:01:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234304AbjEHNBf (ORCPT ); Mon, 8 May 2023 09:01:35 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D13398B0; Mon, 8 May 2023 06:01:32 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 346221FE5E; Mon, 8 May 2023 13:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683550891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+1gz08zY/NsCFjekr1lRb3nLu/+PsgT/Yf2cgH0LZIE=; b=q3VzAzckfIqHsQfhFTFFho0aB7OzCDTihGv9THu6G4A+EAkq8XblxZqivLCnvD3gZzfGpi 5Pjv3GkHTShin5/oSM5vcxrQ28Rj1nMNjS2AIlEaySx2jvX5dpPCWgseHmxlYTUIuHcJG2 h9fmdsTNqodLG4xMznK7T7GXLlLQx2Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683550891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+1gz08zY/NsCFjekr1lRb3nLu/+PsgT/Yf2cgH0LZIE=; b=JPragvHSEt6Re4ujlr8op4PVGdblZOKdIE1/3g0YKLRsvM5MopGx2ht7Cy6I8cp0WlD0LA v+dKqbYx2TYLc9Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F224013A3E; Mon, 8 May 2023 13:01:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6yoSO6ryWGSpXQAAMHmgww (envelope-from ); Mon, 08 May 2023 13:01:30 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 0049EA0754; Sun, 7 May 2023 21:08:11 +0200 (CEST) Date: Sun, 7 May 2023 21:08:11 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jens Axboe , Al Viro , Christian Brauner , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/9] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Message-ID: <20230507190811.qbll5r3jsx35curi@quack3> References: <20230505175132.2236632-1-hch@lst.de> <20230505175132.2236632-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505175132.2236632-2-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri 05-05-23 13:51:24, Christoph Hellwig wrote: > blk_mark_disk_dead does very similar work a a section of del_gendisk: > > - set the GD_DEAD flag > - set the capacity to zero > - start a queue drain > > but del_gendisk also sets QUEUE_FLAG_DYING on the queue if it is owned by > the disk, sets the capacity to zero before starting the drain, and both > with sending a uevent and kernel message for this fake capacity change. > > Move the exact logic from the more heavily used del_gendisk into > blk_mark_disk_dead and then call blk_mark_disk_dead from del_gendisk. > > Signed-off-by: Christoph Hellwig I'm somewhat wondering about the lost notification from blk_mark_disk_dead(). E.g. DM uses blk_mark_disk_dead() so if some udev script depends on the event when DM device gets destroyed, we would break it? Honza > --- > block/genhd.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 90c402771bb570..461999e9489937 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -583,13 +583,22 @@ EXPORT_SYMBOL(device_add_disk); > */ > void blk_mark_disk_dead(struct gendisk *disk) > { > + /* > + * Fail any new I/O. > + */ > set_bit(GD_DEAD, &disk->state); > - blk_queue_start_drain(disk->queue); > + if (test_bit(GD_OWNS_QUEUE, &disk->state)) > + blk_queue_flag_set(QUEUE_FLAG_DYING, disk->queue); > > /* > * Stop buffered writers from dirtying pages that can't be written out. > */ > - set_capacity_and_notify(disk, 0); > + set_capacity(disk, 0); > + > + /* > + * Prevent new I/O from crossing bio_queue_enter(). > + */ > + blk_queue_start_drain(disk->queue); > } > EXPORT_SYMBOL_GPL(blk_mark_disk_dead); > > @@ -632,18 +641,7 @@ void del_gendisk(struct gendisk *disk) > fsync_bdev(disk->part0); > __invalidate_device(disk->part0, true); > > - /* > - * Fail any new I/O. > - */ > - set_bit(GD_DEAD, &disk->state); > - if (test_bit(GD_OWNS_QUEUE, &disk->state)) > - blk_queue_flag_set(QUEUE_FLAG_DYING, q); > - set_capacity(disk, 0); > - > - /* > - * Prevent new I/O from crossing bio_queue_enter(). > - */ > - blk_queue_start_drain(q); > + blk_mark_disk_dead(disk); > > if (!(disk->flags & GENHD_FL_HIDDEN)) { > sysfs_remove_link(&disk_to_dev(disk)->kobj, "bdi"); > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR