From: Al Viro <viro@zeniv.linux.org.uk>
To: houweitao <houweitao@didiglobal.com>
Cc: akpm@linux-foudation.org, xupengfei@nfschina.com,
brauner@kernel.org, dchinner@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
royliyueyi@didiglobal.com
Subject: Re: [PATCH] fs: hfsplus: fix uninit-value bug in hfsplus_listxattr
Date: Thu, 11 May 2023 05:36:02 +0100 [thread overview]
Message-ID: <20230511043602.GG3390869@ZenIV> (raw)
In-Reply-To: <20230510022515.9368-1-houweitao@didiglobal.com>
On Wed, May 10, 2023 at 10:25:15AM +0800, houweitao wrote:
> BUG: KMSAN: uninit-value in strncmp+0x11e/0x180 lib/string.c:307
> strncmp+0x11e/0x180 lib/string.c:307
> is_known_namespace fs/hfsplus/xattr.c:45 [inline]
> name_len fs/hfsplus/xattr.c:397 [inline]
> hfsplus_listxattr+0xe61/0x1aa0 fs/hfsplus/xattr.c:746
> vfs_listxattr fs/xattr.c:473 [inline]
> listxattr+0x700/0x780 fs/xattr.c:820
> path_listxattr fs/xattr.c:844 [inline]
> __do_sys_llistxattr fs/xattr.c:862 [inline]
> __se_sys_llistxattr fs/xattr.c:859 [inline]
> __ia32_sys_llistxattr+0x171/0x300 fs/xattr.c:859
> do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
> __do_fast_syscall_32+0xa2/0x100 arch/x86/entry/common.c:178
> do_fast_syscall_32+0x37/0x80 arch/x86/entry/common.c:203
> do_SYSENTER_32+0x1f/0x30 arch/x86/entry/common.c:246
> entry_SYSENTER_compat_after_hwframe+0x70/0x82
>
> Reported-by: syzbot <syzbot+92ef9ee419803871020e@syzkaller.appspotmail.com>
> Link: https://syzkaller.appspot.com/bug?extid=92ef9ee419803871020e
> Signed-off-by: houweitao <houweitao@didiglobal.com>
Why does it actually fix anything? Other than making KMSAN STFU, that is...
"Fill it with zeroes" might or might not be a fix in this particular case,
but it really needs more detailed proof.
You might have figured it out, but how do I (or anybody else) even begin
to reason about the correctness of that fix? By redoing the analysis from
scratch, starting with "in some conditions this stack trace might end up
reading uninitialized data in strbuf"?
NAK. *IF* you have an explanation of what's going on and why this change
really fixes things, please repost with useful commit message.
next prev parent reply other threads:[~2023-05-11 4:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 2:25 [PATCH] fs: hfsplus: fix uninit-value bug in hfsplus_listxattr houweitao
2023-05-11 4:36 ` Al Viro [this message]
2023-05-12 7:23 ` 侯伟桃 Vincent Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230511043602.GG3390869@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foudation.org \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=houweitao@didiglobal.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=royliyueyi@didiglobal.com \
--cc=xupengfei@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).