From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BB0C7EE2A for ; Fri, 12 May 2023 18:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238959AbjELSck (ORCPT ); Fri, 12 May 2023 14:32:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238860AbjELScj (ORCPT ); Fri, 12 May 2023 14:32:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F03A1BF4; Fri, 12 May 2023 11:32:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FC75657B6; Fri, 12 May 2023 18:31:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68219C43443; Fri, 12 May 2023 18:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683916279; bh=QNtq+dSxf9S4yKVS21hk0h0xMTBN4aqiD72KDFJyBk8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S3eckV/pl26k1JlgpYv0R7kzza2puVetV/PeBl8/OL+6nvWP/BO5PEXTygIWRKUWV xbSja4rYBbpwOG/7GKAJtle5TcPVb/r7fk8oyYwhys+yS3TyDTWNyhg8hbS5DHI3O/ Rm8hlKJn+y/qS4hJ8aZZsSxe640f32ldjp0qCY1273MnyRul8tDEwL9sF5g9CQZTHo 51DuqmZ/1EaPhWY4C8Rr0p5qdOPHiqMhdKa84V5azCajimUcER8gcTU3ccAbd0ZxLR wvLMS3pAr6k5gpBegrqX6caWeLBajjSiv+obtkeZw48No4aSrsVmEEeZH2AlbtwNkt si0W2yVltrr0g== Date: Fri, 12 May 2023 11:31:18 -0700 From: "Darrick J. Wong" To: Sarthak Kukreti Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , Alasdair Kergon , Mike Snitzer , Christoph Hellwig , Brian Foster , Theodore Ts'o , Andreas Dilger , Bart Van Assche , stable@vger.kernel.org Subject: Re: [PATCH v6 1/5] block: Don't invalidate pagecache for invalid falloc modes Message-ID: <20230512183118.GD858791@frogsfrogsfrogs> References: <20230420004850.297045-1-sarthakkukreti@chromium.org> <20230506062909.74601-1-sarthakkukreti@chromium.org> <20230506062909.74601-2-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230506062909.74601-2-sarthakkukreti@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 05, 2023 at 11:29:05PM -0700, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Ideally you'd only take filemap_invalidate_lock for valid modes, but eh who cares about efficiency for the EOPNOTSUPP case, let's move on. :) Reviewed-by: Darrick J. Wong --D > --- > block/fops.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/block/fops.c b/block/fops.c > index d2e6be4e3d1c..4c70fdc546e7 100644 > --- a/block/fops.c > +++ b/block/fops.c > @@ -648,24 +648,35 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start, > > filemap_invalidate_lock(inode->i_mapping); > > - /* Invalidate the page cache, including dirty pages. */ > - error = truncate_bdev_range(bdev, file->f_mode, start, end); > - if (error) > - goto fail; > - > + /* > + * Invalidate the page cache, including dirty pages, for valid > + * de-allocate mode calls to fallocate(). > + */ > switch (mode) { > case FALLOC_FL_ZERO_RANGE: > case FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE: > + error = truncate_bdev_range(bdev, file->f_mode, start, end); > + if (error) > + goto fail; > + > error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, > len >> SECTOR_SHIFT, GFP_KERNEL, > BLKDEV_ZERO_NOUNMAP); > break; > case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE: > + error = truncate_bdev_range(bdev, file->f_mode, start, end); > + if (error) > + goto fail; > + > error = blkdev_issue_zeroout(bdev, start >> SECTOR_SHIFT, > len >> SECTOR_SHIFT, GFP_KERNEL, > BLKDEV_ZERO_NOFALLBACK); > break; > case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE: > + error = truncate_bdev_range(bdev, file->f_mode, start, end); > + if (error) > + goto fail; > + > error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT, > len >> SECTOR_SHIFT, GFP_KERNEL); > break; > -- > 2.40.1.521.gf1e218fcd8-goog >