linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Layton <jlayton@kernel.org>,
	Ondrej Valousek <ondrej.valousek.xm@renesas.com>,
	"trondmy@hammerspace.com" <trondmy@hammerspace.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: A pass-through support for NFSv4 style ACL
Date: Wed, 17 May 2023 09:50:02 +0200	[thread overview]
Message-ID: <20230517-outen-galopp-cf33633006b5@brauner> (raw)
In-Reply-To: <ZGSGCTWOWkwIbvQE@infradead.org>

On Wed, May 17, 2023 at 12:45:13AM -0700, Christoph Hellwig wrote:
> On Wed, May 17, 2023 at 09:42:59AM +0200, Christian Brauner wrote:
> > I have no idea about the original flame war that ended RichACLs in
> > additition to having no clear clue what RichACLs are supposed to
> > achieve. My current knowledge extends to "Christoph didn't like them".
> 
> Christoph certainly doesn't like Rich ACLs, as do many other people.
> 
> But the deal block was that the patchset:
> 
>  - totally duplicated the VFS level ACL handling instead of having
>    a common object for Posix and the new ACLs

Which seems like a pretty obvious choice... That was the first thing I
thought of doing (see earlier mail).

>  - did add even more mess to the already horrible xattr interface
>    instead of adding syscalls.

Plus that was before I moved POSIX ACLs out of the xattr handlers so
they would've had to get that work done first for this to not end up a
horrible horrible mess...

  reply	other threads:[~2023-05-17  7:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 12:46 [PATCH] fs: don't call posix_acl_listxattr in generic_listxattr Jeff Layton
2023-05-16 14:17 ` Christian Brauner
     [not found]   ` <TYXPR01MB18549D3A5B0BE777D7F6B284D9799@TYXPR01MB1854.jpnprd01.prod.outlook.com>
2023-05-16 21:22     ` A pass-through support for NFSv4 style ACL Jeff Layton
2023-05-17  7:42       ` Christian Brauner
2023-05-17  7:45         ` Christoph Hellwig
2023-05-17  7:50           ` Christian Brauner [this message]
2023-05-17  9:29         ` Ondrej Valousek
2023-05-17  9:58         ` Jeff Layton
2023-05-17 12:39         ` Theodore Ts'o
2023-05-19 10:56           ` Christian Brauner
2023-05-19 11:38             ` Ondrej Valousek
2023-05-19 12:02               ` Christian Brauner
2023-09-04 20:36 ` [PATCH] fs: don't call posix_acl_listxattr in generic_listxattr Ondrej Valousek
2023-09-05 10:50   ` Jeff Layton
2023-09-05 11:36     ` Ondrej Valousek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517-outen-galopp-cf33633006b5@brauner \
    --to=brauner@kernel.org \
    --cc=hch@infradead.org \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ondrej.valousek.xm@renesas.com \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).