From: Christoph Hellwig <hch@lst.de>
To: Yihuan Pan <xun794@gmail.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
vgoyal@redhat.com, hch@lst.de
Subject: Re: [PATCH] init: remove unused names parameter in split_fs_names()
Date: Sat, 20 May 2023 09:34:17 +0200 [thread overview]
Message-ID: <20230520073417.GA2463@lst.de> (raw)
In-Reply-To: <4lsiigvaw4lxcs37rlhgepv77xyxym6krkqcpc3xfncnswok3y@b67z3b44orar>
On Sat, May 20, 2023 at 03:23:32PM +0800, Yihuan Pan wrote:
> The split_fs_names() function takes a names parameter, but the function actually uses the root_fs_names global variable instead. This names parameter is not used in the function, so it can be safely removed.
>
> This change does not affect the functionality of split_fs_names() or any other part of the kernel.
Way too long line here.
But I actually have a major rework of this code pending, so let's
please keep off from touching it for now.
next prev parent reply other threads:[~2023-05-20 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 7:23 [PATCH] init: remove unused names parameter in split_fs_names() Yihuan Pan
2023-05-20 7:34 ` Christoph Hellwig [this message]
2023-05-25 9:27 ` Christoph Hellwig
2023-06-05 8:48 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520073417.GA2463@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xun794@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).