From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DBAC77B7F for ; Sat, 20 May 2023 07:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjETHeX (ORCPT ); Sat, 20 May 2023 03:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjETHeW (ORCPT ); Sat, 20 May 2023 03:34:22 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0256118 for ; Sat, 20 May 2023 00:34:20 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C658D68C4E; Sat, 20 May 2023 09:34:17 +0200 (CEST) Date: Sat, 20 May 2023 09:34:17 +0200 From: Christoph Hellwig To: Yihuan Pan Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, hch@lst.de Subject: Re: [PATCH] init: remove unused names parameter in split_fs_names() Message-ID: <20230520073417.GA2463@lst.de> References: <4lsiigvaw4lxcs37rlhgepv77xyxym6krkqcpc3xfncnswok3y@b67z3b44orar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4lsiigvaw4lxcs37rlhgepv77xyxym6krkqcpc3xfncnswok3y@b67z3b44orar> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, May 20, 2023 at 03:23:32PM +0800, Yihuan Pan wrote: > The split_fs_names() function takes a names parameter, but the function actually uses the root_fs_names global variable instead. This names parameter is not used in the function, so it can be safely removed. > > This change does not affect the functionality of split_fs_names() or any other part of the kernel. Way too long line here. But I actually have a major rework of this code pending, so let's please keep off from touching it for now.