From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
David Hildenbrand <david@redhat.com>
Cc: David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Christian Brauner <brauner@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [RFC PATCH 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning
Date: Thu, 25 May 2023 16:50:59 +0100 [thread overview]
Message-ID: <20230525155102.87353-1-dhowells@redhat.com> (raw)
Hi Christoph, David,
Since Christoph asked nicely[1] ;-), here are three patches that go on top
of the similar patches for bio structs now in the block tree that make the
old block direct-IO code use iov_iter_extract_pages() and page pinning.
There are three patches:
(1) Make page pinning not add or remove a pin to/from the ZERO_PAGE,
thereby allowing the dio code to insert zero pages in the middle of
dealing with pinned pages.
(2) Provide a function to allow an additional pin to be taken on a page we
already have pinned (and do nothing for the zero page).
(3) Switch direct-io.c over to using page pinning and to use
iov_iter_extract_pages() so that pages from non-user-backed iterators
aren't pinned.
Note that I haven't managed to test this yet as SELinux is refusing to let
me mount things like ext2 filesystems on account of it not having xattrs:-/
I've pushed the patches here also:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-old-dio
David
Link: https://lore.kernel.org/r/ZGxfrOLZ4aN9/MvE@infradead.org/ [1]
David Howells (3):
mm: Don't pin ZERO_PAGE in pin_user_pages()
mm: Provide a function to get an additional pin on a page
block: Use iov_iter_extract_pages() and page pinning in direct-io.c
fs/direct-io.c | 68 ++++++++++++++++++++++++++++------------------
include/linux/mm.h | 1 +
mm/gup.c | 54 +++++++++++++++++++++++++++++++++++-
3 files changed, 95 insertions(+), 28 deletions(-)
next reply other threads:[~2023-05-25 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 15:50 David Howells [this message]
2023-05-25 15:51 ` [RFC PATCH 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() David Howells
2023-05-25 16:47 ` David Hildenbrand
2023-05-25 15:51 ` [RFC PATCH 2/3] mm: Provide a function to get an additional pin on a page David Howells
2023-05-25 15:51 ` [RFC PATCH 3/3] block: Use iov_iter_extract_pages() and page pinning in direct-io.c David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525155102.87353-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).