linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Pengfei Xu <pengfei.xu@intel.com>,
	Eric Sandeen <sandeen@sandeen.net>,
	dchinner@redhat.com, djwong@kernel.org, heng.su@intel.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	lkp@intel.com, Aleksandr Nogikh <nogikh@google.com>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Syzkaller & bisect] There is "soft lockup in __cleanup_mnt" in v6.4-rc3 kernel
Date: Thu, 25 May 2023 13:55:42 -0400	[thread overview]
Message-ID: <20230525175542.GB821358@mit.edu> (raw)
In-Reply-To: <ZG785SwJtvR4pO/6@dread.disaster.area>

On Thu, May 25, 2023 at 04:15:01PM +1000, Dave Chinner wrote:
> Google's syzbot does this now, so your syzkaller bot should also be
> able to do it....
>
> Please go and talk to the syzkaller authors to find out how they
> extract filesystem images from the reproducer, and any other
> information they've also been asked to provide for triage
> purposes.

Pengfei,

What is it that your syzkaller instance doing that Google's upstream
syzkaller instance is not doing?  Google's syzkaller's team is been
very responsive at improving syzkaller's Web UI, including making it
easy to get artifacts from the syzkaller instance, requesting that
their bot to test a particular git tree or patch (since sometimes
reproducer doesn't easily reproduce on KVM, but easily reproduces in
their Google Cloud VM environment).

So if there is some unique feature which you've added to your syzbot
instances, maybe you can contribute that change upstream, so that
everyone can benefit?  From an upstream developer's perspective, it
also means that I can very easily take a look at the currently active
syzbot reports for a particular subsystem --- for example:

       https://syzkaller.appspot.com/upstream/s/ext4

... and I can see how often a particular syzbot issue reproduces, and
it makes it easier for me to prioritize which syzbot report I should
work on next.  If there is a discussion on a particular report, I can
get a link to that discussion on lore.kernel.org; and once a patch has
been submitted, there is an indication on the dashboard that there is
a PATCH associated with that particular report.

For example, take a look at this report:

	https://syzkaller.appspot.com/bug?extid=e44749b6ba4d0434cd47

... and look at the contents under the Discussion section; and then
open up the "Last patch testing requests" collapsible section.

These are some of the reasons why using Google's instance of syzkaller
is a huge value add --- and quite frankly, it means that I will
prioritize looking at syzkaller reports on the syzkaller.appspot.com
dashboard, where I can easily prioritize which reports are most useful
for me to look at next, over those that you and others might forward
from some company's private syzkaller instance.  It's just far more
productive for me as an upstream maintainer.

Bottom line, having various companies run their own private instances
of syzkaller is much less useful for the upstream community.  If Intel
feels that it's useful to run their own instance, maybe there's some
way you can work with Google syzkaller team so you don't have to do
that?

Are there some improvements to the syzkaller code base Intel would be
willing to contribute to the upstream syzkaller code base at
https://github.com/google/syzkaller?  Or is there some other reason
why Intel is running its own syzkaller instance?

Cheers,

						- Ted

  reply	other threads:[~2023-05-25 17:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25  2:59 [Syzkaller & bisect] There is "soft lockup in __cleanup_mnt" in v6.4-rc3 kernel Pengfei Xu
2023-05-25  3:51 ` Eric Sandeen
2023-05-25  5:44   ` Pengfei Xu
2023-05-25  6:15     ` Dave Chinner
2023-05-25 17:55       ` Theodore Ts'o [this message]
2023-05-26  6:43         ` Pengfei Xu
2023-05-26 17:42         ` Dave Hansen
2023-05-26 20:54           ` Theodore Ts'o
2023-05-26 21:20             ` Dave Hansen
2023-05-26  4:55       ` Pengfei Xu
2023-05-25 14:17     ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525175542.GB821358@mit.edu \
    --to=tytso@mit.edu \
    --cc=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=dvyukov@google.com \
    --cc=heng.su@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nogikh@google.com \
    --cc=pengfei.xu@intel.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).