From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C92C77B7E for ; Sun, 28 May 2023 17:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjE1Rvr (ORCPT ); Sun, 28 May 2023 13:51:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjE1Rvq (ORCPT ); Sun, 28 May 2023 13:51:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75612A0; Sun, 28 May 2023 10:51:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1108B60DFC; Sun, 28 May 2023 17:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 012E2C433D2; Sun, 28 May 2023 17:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685296304; bh=V5r5hC5QR4ICHfDH4iKLn7xpPteStIXwKbPBMf+1154=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BC8d4bWbKTVGtHhC+p+r5nXpeWwa6mk656+2fAIewu2QhZ0P7REuIxGe7oGB3SN10 5ik0Yy0AFO8qzcUMfYToT1dsPmZbhcorvV6Q7KPTiOSLjxY7jNQ1sueeVQhu5rUi7B /+sGT2D2FVxEYn2A+ksL15YDFsbMglgY7UKE98Rk= Date: Sun, 28 May 2023 18:51:41 +0100 From: Greg KH To: Prince Kumar Maurya Cc: skhan@linuxfoundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, chenzhongjin@huawei.com, syzkaller-bugs@googlegroups.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Null check to prevent null-ptr-deref bug Message-ID: <2023052815-deface-crux-4634@gregkh> References: <000000000000cafb9305fc4fe588@google.com> <20230528173546.593511-1-princekumarmaurya06@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230528173546.593511-1-princekumarmaurya06@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, May 28, 2023 at 10:35:46AM -0700, Prince Kumar Maurya wrote: > sb_getblk(inode->i_sb, parent) return a null ptr and taking lock on > that leads to the null-ptr-deref bug. > > Signed-off-by: Prince Kumar Maurya > --- > Change since v1: update the commit message. Your subject: line needs to also be fixed up. Please see the kernel documentation for how to do this properly. thanks greg k-h