From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F24C77B7E for ; Sun, 28 May 2023 17:52:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjE1RwR (ORCPT ); Sun, 28 May 2023 13:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjE1RwQ (ORCPT ); Sun, 28 May 2023 13:52:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2DEA9; Sun, 28 May 2023 10:52:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45A0360F39; Sun, 28 May 2023 17:52:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62576C433D2; Sun, 28 May 2023 17:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685296333; bh=4HvaVQR1ubJwphBZulWTFAhkUjWttPrNPN9+qUwM4Yg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=otrqXXqbeNYZ5LbkbRSPIJwObcvyPPgJBuvBNksIdu1rZQDPwIjqBsbP1+VjbVl2k ODRP21Laqudk2kShW850by1GxOaBM2jVPIkbLv7WpNIcq1KjayetGg4jL25yPXzIzF K2FrLqs+uJwlDRo89wdT3A/WbRgVfCYcDnjNXwtc= Date: Sun, 28 May 2023 18:52:11 +0100 From: Greg KH To: Prince Kumar Maurya Cc: skhan@linuxfoundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, chenzhongjin@huawei.com, syzkaller-bugs@googlegroups.com, linux-kernel-mentees@lists.linuxfoundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Null check to prevent null-ptr-deref bug Message-ID: <2023052852-footwork-sanding-e450@gregkh> References: <000000000000cafb9305fc4fe588@google.com> <20230528173546.593511-1-princekumarmaurya06@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230528173546.593511-1-princekumarmaurya06@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, May 28, 2023 at 10:35:46AM -0700, Prince Kumar Maurya wrote: > sb_getblk(inode->i_sb, parent) return a null ptr and taking lock on > that leads to the null-ptr-deref bug. > > Signed-off-by: Prince Kumar Maurya > --- > Change since v1: update the commit message. > The bug was reproducible using the reproducer code and assets found in > bug report:https://syzkaller.appspot.com/bug?extid=aad58150cbc64ba41bdc Also, did you forget to properly credit the syzbot tool like it asks you to?