From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: introduce bdev holder ops and a file system shutdown method v3
Date: Thu, 1 Jun 2023 11:44:43 +0200 [thread overview]
Message-ID: <20230601094459.1350643-1-hch@lst.de> (raw)
Hi all,
this series fixes the long standing problem that we never had a good way
to communicate block device events to the user of the block device.
It fixes this by introducing a new set of holder ops registered at
blkdev_get_by_* time for the exclusive holder, and then wire that up
to a shutdown super operation to report the block device remove to the
file systems.
Changes since v2:
- rename a method in xfs
- add ext4 support
Changes since v1:
- add a patch to refactor bd_may_claim
- add a sanity check for mismatching holder ops in bd_may_claim
- move partition removal later in del_gendisk so that partitions
are still around for the shutdown notification
- add SHUTDOWN_DEVICE_REMOVED to XFS_SHUTDOWN_STRINGS
Diffstat:
block/bdev.c | 159 ++++++++++++++++++++----------------
block/blk.h | 2
block/fops.c | 2
block/genhd.c | 78 +++++++++++++----
block/ioctl.c | 3
block/partitions/core.c | 31 +++----
drivers/block/drbd/drbd_nl.c | 3
drivers/block/loop.c | 2
drivers/block/pktcdvd.c | 5 -
drivers/block/rnbd/rnbd-srv.c | 2
drivers/block/xen-blkback/xenbus.c | 2
drivers/block/zram/zram_drv.c | 2
drivers/md/bcache/super.c | 2
drivers/md/dm.c | 2
drivers/md/md.c | 2
drivers/mtd/devices/block2mtd.c | 4
drivers/nvme/target/io-cmd-bdev.c | 2
drivers/s390/block/dasd_genhd.c | 2
drivers/target/target_core_iblock.c | 2
drivers/target/target_core_pscsi.c | 3
fs/btrfs/dev-replace.c | 2
fs/btrfs/volumes.c | 6 -
fs/erofs/super.c | 2
fs/ext4/ext4.h | 1
fs/ext4/ioctl.c | 24 +++--
fs/ext4/super.c | 18 +++-
fs/f2fs/super.c | 4
fs/jfs/jfs_logmgr.c | 2
fs/nfs/blocklayout/dev.c | 5 -
fs/nilfs2/super.c | 2
fs/ocfs2/cluster/heartbeat.c | 2
fs/reiserfs/journal.c | 5 -
fs/super.c | 21 ++++
fs/xfs/xfs_fsops.c | 3
fs/xfs/xfs_mount.h | 4
fs/xfs/xfs_super.c | 21 ++++
include/linux/blk_types.h | 2
include/linux/blkdev.h | 12 ++
include/linux/fs.h | 1
kernel/power/swap.c | 4
mm/swapfile.c | 3
41 files changed, 297 insertions(+), 157 deletions(-)
next reply other threads:[~2023-06-01 9:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 9:44 Christoph Hellwig [this message]
2023-06-01 9:44 ` [PATCH 01/16] block: factor out a bd_end_claim helper from blkdev_put Christoph Hellwig
2023-06-01 9:44 ` [PATCH 02/16] block: refactor bd_may_claim Christoph Hellwig
2023-06-01 9:44 ` [PATCH 03/16] block: turn bdev_lock into a mutex Christoph Hellwig
2023-06-01 9:44 ` [PATCH 04/16] block: consolidate the shutdown logic in blk_mark_disk_dead and del_gendisk Christoph Hellwig
2023-06-01 9:44 ` [PATCH 05/16] block: avoid repeated work in blk_mark_disk_dead Christoph Hellwig
2023-06-01 9:44 ` [PATCH 06/16] block: unhash the inode earlier in delete_partition Christoph Hellwig
2023-06-01 9:44 ` [PATCH 07/16] block: delete partitions later in del_gendisk Christoph Hellwig
2023-06-01 9:44 ` [PATCH 08/16] block: remove blk_drop_partitions Christoph Hellwig
2023-06-01 9:44 ` [PATCH 09/16] block: introduce holder ops Christoph Hellwig
2023-06-01 9:44 ` [PATCH 10/16] block: add a mark_dead holder operation Christoph Hellwig
2023-06-01 9:44 ` [PATCH 11/16] fs: add a method to shut down the file system Christoph Hellwig
2023-06-01 9:44 ` [PATCH 12/16] xfs: wire up sops->shutdown Christoph Hellwig
2023-06-01 9:44 ` [PATCH 13/16] xfs: wire up the ->mark_dead holder operation for log and RT devices Christoph Hellwig
2023-06-01 9:44 ` [PATCH 14/16] ext4: split ext4_shutdown Christoph Hellwig
2023-06-01 10:10 ` Jan Kara
2023-06-01 9:44 ` [PATCH 15/16] ext4: wire up sops->shutdown Christoph Hellwig
2023-06-01 10:10 ` Jan Kara
2023-06-01 9:44 ` [PATCH 16/16] ext4: wire up the ->mark_dead holder operation for log devices Christoph Hellwig
2023-06-01 10:11 ` Jan Kara
2023-06-01 21:48 ` introduce bdev holder ops and a file system shutdown method v3 Dave Chinner
2023-06-05 17:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601094459.1350643-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).