From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [bug report] fs: Restrict lock_two_nondirectories() to non-directory inodes
Date: Wed, 7 Jun 2023 09:23:34 +0200 [thread overview]
Message-ID: <20230607-frucht-stillen-285dfd2573fe@brauner> (raw)
In-Reply-To: <20230606095625.zowqbpfi7hktfbwh@quack3>
On Tue, Jun 06, 2023 at 11:56:25AM +0200, Jan Kara wrote:
> On Tue 06-06-23 11:32:53, Dan Carpenter wrote:
> > Hello Jan Kara,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch afb4adc7c3ef: "fs: Restrict lock_two_nondirectories() to
> > non-directory inodes" from Jun 1, 2023, leads to the following Smatch
> > complaint:
> >
> > fs/inode.c:1174 unlock_two_nondirectories()
> > warn: variable dereferenced before check 'inode1' (see line 1172)
> >
> > fs/inode.c:1176 unlock_two_nondirectories()
> > warn: variable dereferenced before check 'inode2' (see line 1173)
>
> Indeed, thanks for spotting this! Luckily there are currently no in-tree
> users passing NULL. Attached patch fixes this. Christian, can you please
Thanks for the fixup!
> add this to your branch or squash it into the fixed commit? Thanks!
Of course. I've squashed the fix into the original patch.
---
Applied to the vfs.rename.locking branch of the vfs/vfs.git tree.
Patches in the vfs.rename.locking branch should appear in linux-next soon.
prev parent reply other threads:[~2023-06-07 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:32 [bug report] fs: Restrict lock_two_nondirectories() to non-directory inodes Dan Carpenter
2023-06-06 9:56 ` Jan Kara
2023-06-07 7:23 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607-frucht-stillen-285dfd2573fe@brauner \
--to=brauner@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).