From: Kees Cook <keescook@chromium.org>
To: Tom Rix <trix@redhat.com>
Cc: mcgrof@kernel.org, yzaikin@google.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static
Date: Tue, 13 Jun 2023 13:30:47 -0700 [thread overview]
Message-ID: <202306131330.AAC4C43AC@keescook> (raw)
In-Reply-To: <20230611120725.183182-1-trix@redhat.com>
On Sun, Jun 11, 2023 at 08:07:25AM -0400, Tom Rix wrote:
> smatch reports
> fs/proc/proc_sysctl.c:32:18: warning: symbol
> 'sysctl_mount_point' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-06-13 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-11 12:07 [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static Tom Rix
2023-06-13 20:30 ` Kees Cook [this message]
2023-06-30 23:20 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306131330.AAC4C43AC@keescook \
--to=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=trix@redhat.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).