From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
Christoph Hellwig <hch@lst.de>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] fs: use helpers for opening kernel internal files
Date: Thu, 15 Jun 2023 06:26:55 +0200 [thread overview]
Message-ID: <20230615042655.GB4508@lst.de> (raw)
In-Reply-To: <20230614120917.2037482-1-amir73il@gmail.com>
On Wed, Jun 14, 2023 at 03:09:17PM +0300, Amir Goldstein wrote:
> Overlayfs and cachefiles use vfs_open_tmpfile() to open a tmpfile
> without accounting for nr_files.
>
> Rename this helper to kernel_tmpfile_open() to better reflect this
> helper is used for kernel internal users.
>
> cachefiles uses open_with_fake_path() without the need for a fake path
> only to use the noaccount feature of open_with_fake_path().
>
> Fork open_with_fake_path() to kernel_file_open() which only does the
> noaccount feature and use it in cachefiles.
Please split this into two patches, one for the
vfs_tmpfile_open rename, and one for the kernel_file_open helper.
> +EXPORT_SYMBOL(kernel_file_open);
EXPORT_SYMBOL_GPL, please.
next prev parent reply other threads:[~2023-06-15 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 12:09 [PATCH] fs: use helpers for opening kernel internal files Amir Goldstein
2023-06-15 4:26 ` Christoph Hellwig [this message]
2023-06-15 11:29 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615042655.GB4508@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).