From: "Darrick J. Wong" <djwong@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: Matthew Wilcox <willy@infradead.org>,
axboe@kernel.dk, song@kernel.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, xiang@kernel.org, chao@kernel.org,
huyue2@coolpad.com, jefflexu@linux.alibaba.com,
hch@infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask()
Date: Wed, 28 Jun 2023 21:34:36 -0700 [thread overview]
Message-ID: <20230629043436.GL11467@frogsfrogsfrogs> (raw)
In-Reply-To: <ee27ca83-a144-7468-4515-efa93f01aa43@vivo.com>
On Thu, Jun 29, 2023 at 11:44:35AM +0800, Yangtao Li wrote:
> On 2023/6/29 0:46, Matthew Wilcox wrote:
>
> > On Wed, Jun 28, 2023 at 05:34:54PM +0800, Yangtao Li wrote:
> > > Introduce queue_logical_block_mask() and bdev_logical_block_mask()
> > > to simplify code, which replace (queue_logical_block_size(q) - 1)
> > > and (bdev_logical_block_size(bdev) - 1).
> > The thing is that I know what queue_logical_block_size - 1 does.
> > That's the low bits. _Which_ bits are queue_logical_block_mask?
> > The high bits or the low bits? And before you say "It's obviously",
> > we have both ways round in the kernel today.
>
>
> I guess for this you mentioned, can we name it bdev_logical_block_lmask and
> queue_logical_block_lmask?
{bdev,queue}_offset_in_lba() ?
--D
>
> Thx,
>
> >
> > I am not in favour of this change. I might be in favour of bool
> > queue_logical_block_aligned(q, x), but even then it doesn't seem worth
> > the bits.
next prev parent reply other threads:[~2023-06-29 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 9:34 [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` [PATCH 2/7] block: Convert to bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` [PATCH 3/7] md: Convert to queue_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` [PATCH 4/7] buffer: Convert to bdev_logical_block_mask() Yangtao Li
2023-06-28 9:34 ` [PATCH 5/7] iomap: " Yangtao Li
2023-06-28 9:34 ` [PATCH 6/7] xfs: " Yangtao Li
2023-06-28 16:41 ` Bill O'Donnell
2023-06-28 9:35 ` [PATCH 7/7] erofs: " Yangtao Li
2023-06-28 16:45 ` [PATCH 1/7] block: add queue_logical_block_mask() and bdev_logical_block_mask() Bill O'Donnell
2023-06-28 16:46 ` Matthew Wilcox
2023-06-29 3:44 ` Yangtao Li
2023-06-29 4:34 ` Darrick J. Wong [this message]
2023-06-29 5:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629043436.GL11467@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=hch@infradead.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).