linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hao Xu <hao.xu@linux.dev>
To: fuse-devel@lists.sourceforge.net
Cc: miklos@szeredi.hu, bernd.schubert@fastmail.fm,
	linux-fsdevel@vger.kernel.org, Wanpeng Li <wanpengli@tencent.com>,
	cgxu519@mykernel.net
Subject: [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode
Date: Fri, 30 Jun 2023 17:46:02 +0800	[thread overview]
Message-ID: <20230630094602.230573-4-hao.xu@linux.dev> (raw)
In-Reply-To: <20230630094602.230573-1-hao.xu@linux.dev>

From: Hao Xu <howeyxu@tencent.com>

In direct_io_relax mode, there can be shared mmaped files and thus dirty
pages in its page cache. Therefore those dirty pages should be written
back to backend before direct write to avoid data loss.

Signed-off-by: Hao Xu <howeyxu@tencent.com>
---
 fs/fuse/file.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 176f719f8fc8..7c9167c62bf6 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1485,6 +1485,13 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
 	if (!ia)
 		return -ENOMEM;
 
+	if (fopen_direct_write && fc->direct_io_relax) {
+		res = filemap_write_and_wait_range(mapping, pos, pos + count - 1);
+		if (res) {
+			fuse_io_free(ia);
+			return res;
+		}
+	}
 	if (!cuse && fuse_range_is_writeback(inode, idx_from, idx_to)) {
 		if (!write)
 			inode_lock(inode);
-- 
2.25.1


  parent reply	other threads:[~2023-06-30  9:46 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30  9:45 [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30  9:46 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Hao Xu
2023-06-30 10:32   ` Bernd Schubert
2023-07-21  3:34   ` [fuse-devel] " Jiachen Zhang
2023-06-30  9:46 ` [PATCH 2/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-06-30 10:35   ` Bernd Schubert
2023-06-30  9:46 ` Hao Xu [this message]
2023-06-30 10:40   ` [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode Bernd Schubert
2023-07-21  6:35   ` [External] [fuse-devel] " Jiachen Zhang
2023-07-21 11:27     ` Hao Xu
2023-07-21 11:56       ` Bernd Schubert
2023-07-25 10:11         ` Hao Xu
2023-07-25 13:00           ` Bernd Schubert
2023-07-25 16:57             ` Hao Xu
2023-07-25 17:59               ` Bernd Schubert
2023-07-27  9:42                 ` Hao Xu
2023-07-26 11:07               ` Jiachen Zhang
2023-07-26 13:15                 ` Bernd Schubert
2023-07-27  2:24                   ` Jiachen Zhang
2023-07-27 10:31                 ` Hao Xu
2023-07-28  2:57                   ` Jiachen Zhang
2023-07-27 10:48                 ` Hao Xu
2023-07-05 10:23 ` [RFC] [PATCH] fuse: DIO writes always use the same code path Bernd Schubert
2023-07-06 14:43   ` Christoph Hellwig
2023-07-07 13:36     ` Bernd Schubert
2023-07-17  8:03   ` Hao Xu
2023-07-17 21:17     ` Bernd Schubert
2023-07-20  7:32 ` [PATCH v3 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
  -- strict thread matches above, loose matches on Subject: below --
2023-08-01  8:06 [PATCH v4 " Hao Xu
2023-08-01  8:06 ` [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode Hao Xu
2023-08-03  4:43   ` Jiachen Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230630094602.230573-4-hao.xu@linux.dev \
    --to=hao.xu@linux.dev \
    --cc=bernd.schubert@fastmail.fm \
    --cc=cgxu519@mykernel.net \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).