linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libfs: fix table format warning
@ 2023-07-04  4:46 Randy Dunlap
  2023-07-04  7:47 ` Christian Brauner
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-07-04  4:46 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Stephen Rothwell, Christian Brauner, Chuck Lever,
	linux-fsdevel, Jonathan Corbet, linux-doc

Drop the unnecessary colon to make the table formatting correct.
The colons are not needed and this file uses them sometimes and
doesn't at other times. Generally they are not preferred in
documentation tables IMO.

Also extend the table line widths to match the table text.

Fixes: 7a3472ae9614 ("libfs: Add directory operations for stable offsets")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/linux-next/20230704135149.014516c7@canb.auug.org.au/T/#u
Cc: Christian Brauner <brauner@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-fsdevel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
 Documentation/filesystems/locking.rst |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff -- a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
--- a/Documentation/filesystems/locking.rst
+++ b/Documentation/filesystems/locking.rst
@@ -90,9 +90,9 @@ prototypes::
 locking rules:
 	all may block
 
-==============	=============================================
+==============	==================================================
 ops		i_rwsem(inode)
-==============	=============================================
+==============	==================================================
 lookup:		shared
 create:		exclusive
 link:		exclusive (both)
@@ -116,8 +116,8 @@ atomic_open:	shared (exclusive if O_CREA
 tmpfile:	no
 fileattr_get:	no or exclusive
 fileattr_set:	exclusive
-get_offset_ctx: no
-==============	=============================================
+get_offset_ctx  no
+==============	==================================================
 
 
 	Additionally, ->rmdir(), ->unlink() and ->rename() have ->i_rwsem

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libfs: fix table format warning
  2023-07-04  4:46 [PATCH] libfs: fix table format warning Randy Dunlap
@ 2023-07-04  7:47 ` Christian Brauner
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2023-07-04  7:47 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Christian Brauner, Stephen Rothwell, Chuck Lever, linux-fsdevel,
	Jonathan Corbet, linux-doc, linux-kernel

On Mon, 03 Jul 2023 21:46:43 -0700, Randy Dunlap wrote:
> Drop the unnecessary colon to make the table formatting correct.
> The colons are not needed and this file uses them sometimes and
> doesn't at other times. Generally they are not preferred in
> documentation tables IMO.
> 
> Also extend the table line widths to match the table text.
> 
> [...]

I've folded this fix into Chuck's series. Thanks!

---

Applied to the vfs.readdir branch of the vfs/vfs.git tree.
Patches in the vfs.readdir branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.readdir

[1/1] libfs: Add directory operations for stable offsets
      https://git.kernel.org/vfs/vfs/c/2b1732fc0a7c

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-04  7:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04  4:46 [PATCH] libfs: fix table format warning Randy Dunlap
2023-07-04  7:47 ` Christian Brauner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).