From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nilfs@vger.kernel.org
Subject: [PATCH v2 59/92] nilfs2: convert to ctime accessor functions
Date: Wed, 5 Jul 2023 15:01:24 -0400 [thread overview]
Message-ID: <20230705190309.579783-57-jlayton@kernel.org> (raw)
In-Reply-To: <20230705190309.579783-1-jlayton@kernel.org>
In later patches, we're going to change how the inode's ctime field is
used. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nilfs2/dir.c | 6 +++---
fs/nilfs2/inode.c | 12 ++++++------
fs/nilfs2/ioctl.c | 2 +-
fs/nilfs2/namei.c | 8 ++++----
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/fs/nilfs2/dir.c b/fs/nilfs2/dir.c
index decd6471300b..bce734b68f08 100644
--- a/fs/nilfs2/dir.c
+++ b/fs/nilfs2/dir.c
@@ -429,7 +429,7 @@ void nilfs_set_link(struct inode *dir, struct nilfs_dir_entry *de,
nilfs_set_de_type(de, inode);
nilfs_commit_chunk(page, mapping, from, to);
nilfs_put_page(page);
- dir->i_mtime = dir->i_ctime = current_time(dir);
+ dir->i_mtime = inode_set_ctime_current(dir);
}
/*
@@ -519,7 +519,7 @@ int nilfs_add_link(struct dentry *dentry, struct inode *inode)
de->inode = cpu_to_le64(inode->i_ino);
nilfs_set_de_type(de, inode);
nilfs_commit_chunk(page, page->mapping, from, to);
- dir->i_mtime = dir->i_ctime = current_time(dir);
+ dir->i_mtime = inode_set_ctime_current(dir);
nilfs_mark_inode_dirty(dir);
/* OFFSET_CACHE */
out_put:
@@ -567,7 +567,7 @@ int nilfs_delete_entry(struct nilfs_dir_entry *dir, struct page *page)
pde->rec_len = nilfs_rec_len_to_disk(to - from);
dir->inode = 0;
nilfs_commit_chunk(page, mapping, from, to);
- inode->i_ctime = inode->i_mtime = current_time(inode);
+ inode->i_mtime = inode_set_ctime_current(inode);
out:
nilfs_put_page(page);
return err;
diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c
index a8ce522ac747..5259b94ca1dc 100644
--- a/fs/nilfs2/inode.c
+++ b/fs/nilfs2/inode.c
@@ -366,7 +366,7 @@ struct inode *nilfs_new_inode(struct inode *dir, umode_t mode)
atomic64_inc(&root->inodes_count);
inode_init_owner(&nop_mnt_idmap, inode, dir, mode);
inode->i_ino = ino;
- inode->i_mtime = inode->i_atime = inode->i_ctime = current_time(inode);
+ inode->i_mtime = inode->i_atime = inode_set_ctime_current(inode);
if (S_ISREG(mode) || S_ISDIR(mode) || S_ISLNK(mode)) {
err = nilfs_bmap_read(ii->i_bmap, NULL);
@@ -450,10 +450,10 @@ int nilfs_read_inode_common(struct inode *inode,
set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
inode->i_size = le64_to_cpu(raw_inode->i_size);
inode->i_atime.tv_sec = le64_to_cpu(raw_inode->i_mtime);
- inode->i_ctime.tv_sec = le64_to_cpu(raw_inode->i_ctime);
+ inode_set_ctime(inode, le64_to_cpu(raw_inode->i_ctime),
+ le32_to_cpu(raw_inode->i_ctime_nsec));
inode->i_mtime.tv_sec = le64_to_cpu(raw_inode->i_mtime);
inode->i_atime.tv_nsec = le32_to_cpu(raw_inode->i_mtime_nsec);
- inode->i_ctime.tv_nsec = le32_to_cpu(raw_inode->i_ctime_nsec);
inode->i_mtime.tv_nsec = le32_to_cpu(raw_inode->i_mtime_nsec);
if (nilfs_is_metadata_file_inode(inode) && !S_ISREG(inode->i_mode))
return -EIO; /* this inode is for metadata and corrupted */
@@ -768,9 +768,9 @@ void nilfs_write_inode_common(struct inode *inode,
raw_inode->i_gid = cpu_to_le32(i_gid_read(inode));
raw_inode->i_links_count = cpu_to_le16(inode->i_nlink);
raw_inode->i_size = cpu_to_le64(inode->i_size);
- raw_inode->i_ctime = cpu_to_le64(inode->i_ctime.tv_sec);
+ raw_inode->i_ctime = cpu_to_le64(inode_get_ctime(inode).tv_sec);
raw_inode->i_mtime = cpu_to_le64(inode->i_mtime.tv_sec);
- raw_inode->i_ctime_nsec = cpu_to_le32(inode->i_ctime.tv_nsec);
+ raw_inode->i_ctime_nsec = cpu_to_le32(inode_get_ctime(inode).tv_nsec);
raw_inode->i_mtime_nsec = cpu_to_le32(inode->i_mtime.tv_nsec);
raw_inode->i_blocks = cpu_to_le64(inode->i_blocks);
@@ -875,7 +875,7 @@ void nilfs_truncate(struct inode *inode)
nilfs_truncate_bmap(ii, blkoff);
- inode->i_mtime = inode->i_ctime = current_time(inode);
+ inode->i_mtime = inode_set_ctime_current(inode);
if (IS_SYNC(inode))
nilfs_set_transaction_flag(NILFS_TI_SYNC);
diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
index 1dfbc0c34513..40ffade49f38 100644
--- a/fs/nilfs2/ioctl.c
+++ b/fs/nilfs2/ioctl.c
@@ -149,7 +149,7 @@ int nilfs_fileattr_set(struct mnt_idmap *idmap,
NILFS_I(inode)->i_flags = oldflags | (flags & FS_FL_USER_MODIFIABLE);
nilfs_set_inode_flags(inode);
- inode->i_ctime = current_time(inode);
+ inode_set_ctime_current(inode);
if (IS_SYNC(inode))
nilfs_set_transaction_flag(NILFS_TI_SYNC);
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c
index c7024da8f1e2..2a4e7f4a8102 100644
--- a/fs/nilfs2/namei.c
+++ b/fs/nilfs2/namei.c
@@ -185,7 +185,7 @@ static int nilfs_link(struct dentry *old_dentry, struct inode *dir,
if (err)
return err;
- inode->i_ctime = current_time(inode);
+ inode_set_ctime_current(inode);
inode_inc_link_count(inode);
ihold(inode);
@@ -283,7 +283,7 @@ static int nilfs_do_unlink(struct inode *dir, struct dentry *dentry)
if (err)
goto out;
- inode->i_ctime = dir->i_ctime;
+ inode_set_ctime_to_ts(inode, inode_get_ctime(dir));
drop_nlink(inode);
err = 0;
out:
@@ -387,7 +387,7 @@ static int nilfs_rename(struct mnt_idmap *idmap,
goto out_dir;
nilfs_set_link(new_dir, new_de, new_page, old_inode);
nilfs_mark_inode_dirty(new_dir);
- new_inode->i_ctime = current_time(new_inode);
+ inode_set_ctime_current(new_inode);
if (dir_de)
drop_nlink(new_inode);
drop_nlink(new_inode);
@@ -406,7 +406,7 @@ static int nilfs_rename(struct mnt_idmap *idmap,
* Like most other Unix systems, set the ctime for inodes on a
* rename.
*/
- old_inode->i_ctime = current_time(old_inode);
+ inode_set_ctime_current(old_inode);
nilfs_delete_entry(old_de, old_page);
--
2.41.0
next prev parent reply other threads:[~2023-07-05 19:09 UTC|newest]
Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230705185755.579053-1-jlayton@kernel.org>
2023-07-05 19:00 ` [PATCH v2 01/92] ibmvmc: update ctime in conjunction with mtime on write Jeff Layton
2023-07-05 19:00 ` [PATCH v2 02/92] bfs: update ctime in addition to mtime when adding entries Jeff Layton
2023-07-05 19:00 ` [PATCH v2 03/92] efivarfs: update ctime when mtime changes on a write Jeff Layton
2023-07-05 19:00 ` [PATCH v2 04/92] exfat: ensure that ctime is updated whenever the mtime is Jeff Layton
2023-07-05 19:00 ` [PATCH v2 05/92] apparmor: update ctime whenever the mtime changes on an inode Jeff Layton
2023-07-05 19:00 ` [PATCH v2 06/92] cifs: update the ctime on a partial page write Jeff Layton
[not found] ` <CAH2r5mv+Fc9PuNtb8qMTwpb8qrEO2Tta5+o=mxD-2AY0cU5Aeg@mail.gmail.com>
2023-07-06 7:11 ` Christian Brauner
2023-07-06 15:26 ` Steve French
2023-07-05 19:00 ` [PATCH v2 09/92] btrfs: convert to simple_rename_timestamp Jeff Layton
2023-07-05 19:00 ` [PATCH v2 10/92] ubifs: " Jeff Layton
2023-07-06 10:30 ` Jan Kara
2023-07-06 12:08 ` Zhihao Cheng
2023-07-05 19:00 ` [PATCH v2 11/92] shmem: " Jeff Layton
2023-07-06 10:33 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 12/92] exfat: " Jeff Layton
2023-07-06 10:39 ` Jan Kara
2023-07-06 11:40 ` Jeff Layton
2023-07-05 19:00 ` [PATCH v2 13/92] ntfs3: " Jeff Layton
2023-07-06 10:40 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 14/92] reiserfs: " Jeff Layton
2023-07-06 10:32 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 15/92] spufs: convert to ctime accessor functions Jeff Layton
2023-07-06 11:34 ` Arnd Bergmann
2023-07-05 19:00 ` [PATCH v2 16/92] s390: " Jeff Layton
2023-07-12 12:56 ` Alexander Gordeev
2023-07-05 19:00 ` [PATCH v2 17/92] binderfs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 18/92] infiniband: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 19/92] ibm: " Jeff Layton
2023-07-06 10:41 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 20/92] usb: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 21/92] 9p: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 22/92] adfs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 23/92] affs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 24/92] afs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 25/92] fs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 26/92] autofs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 27/92] befs: " Jeff Layton
2023-07-05 19:00 ` [PATCH v2 28/92] bfs: " Jeff Layton
2023-07-06 10:44 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 29/92] btrfs: " Jeff Layton
2023-07-06 10:51 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 30/92] ceph: " Jeff Layton
2023-07-06 10:53 ` Jan Kara
2023-07-06 11:47 ` Jeff Layton
2023-07-05 19:00 ` [PATCH v2 31/92] coda: " Jeff Layton
2023-07-06 10:54 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 32/92] configfs: " Jeff Layton
2023-07-06 10:54 ` Jan Kara
2023-07-06 22:12 ` Joel Becker
2023-07-05 19:00 ` [PATCH v2 33/92] cramfs: " Jeff Layton
2023-07-06 10:55 ` Jan Kara
2023-07-05 19:00 ` [PATCH v2 34/92] debugfs: " Jeff Layton
2023-07-06 10:55 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 35/92] devpts: " Jeff Layton
2023-07-06 10:56 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 36/92] ecryptfs: " Jeff Layton
2023-07-06 10:56 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 37/92] efivarfs: " Jeff Layton
2023-07-06 10:57 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 38/92] efs: " Jeff Layton
2023-07-06 10:57 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 39/92] erofs: " Jeff Layton
2023-07-06 11:00 ` Jan Kara
2023-07-06 11:53 ` Jeff Layton
2023-07-06 15:12 ` Gao Xiang
2023-07-05 19:01 ` [PATCH v2 40/92] exfat: " Jeff Layton
2023-07-06 11:01 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 41/92] ext2: " Jeff Layton
2023-07-06 11:03 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 42/92] ext4: " Jeff Layton
2023-07-06 12:36 ` Jan Kara
2023-07-06 13:10 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 43/92] f2fs: " Jeff Layton
2023-07-06 11:18 ` Jan Kara
2023-09-04 18:11 ` [f2fs-dev] " patchwork-bot+f2fs
2023-07-05 19:01 ` [PATCH v2 44/92] fat: " Jeff Layton
2023-07-06 1:54 ` OGAWA Hirofumi
2023-07-06 11:25 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 45/92] freevxfs: " Jeff Layton
2023-07-06 11:19 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 46/92] fuse: " Jeff Layton
2023-07-06 11:20 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 47/92] gfs2: " Jeff Layton
2023-07-06 12:54 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 48/92] hfs: " Jeff Layton
2023-07-06 12:50 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 49/92] hfsplus: " Jeff Layton
2023-07-06 12:49 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 50/92] hostfs: " Jeff Layton
2023-07-06 12:48 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 51/92] hpfs: " Jeff Layton
2023-07-06 12:47 ` Jan Kara
2023-07-06 13:11 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 52/92] hugetlbfs: " Jeff Layton
2023-07-05 19:58 ` Mike Kravetz
2023-07-06 12:40 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 53/92] isofs: " Jeff Layton
2023-07-06 12:39 ` Jan Kara
2023-07-06 13:11 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 54/92] jffs2: " Jeff Layton
2023-07-06 13:25 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 55/92] jfs: " Jeff Layton
2023-07-06 13:27 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 56/92] kernfs: " Jeff Layton
2023-07-06 13:32 ` Jan Kara
2023-07-06 13:50 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 57/92] nfs: " Jeff Layton
2023-07-06 13:34 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 58/92] nfsd: " Jeff Layton
2023-07-06 13:34 ` Jan Kara
2023-07-05 19:01 ` Jeff Layton [this message]
2023-07-06 13:35 ` [PATCH v2 59/92] nilfs2: " Jan Kara
2023-07-05 19:01 ` [PATCH v2 60/92] ntfs: " Jeff Layton
2023-07-06 13:37 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 61/92] ntfs3: " Jeff Layton
2023-07-06 13:47 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 62/92] ocfs2: " Jeff Layton
2023-07-06 13:51 ` Jan Kara
2023-07-07 3:15 ` Joseph Qi
2023-07-07 10:07 ` Jeff Layton
2023-07-09 13:59 ` Joseph Qi
2023-07-05 19:01 ` [PATCH v2 63/92] omfs: " Jeff Layton
2023-07-06 13:52 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 64/92] openpromfs: " Jeff Layton
2023-07-06 13:52 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 65/92] orangefs: " Jeff Layton
2023-07-06 13:55 ` Jan Kara
2023-07-06 13:56 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 66/92] overlayfs: " Jeff Layton
2023-07-06 13:58 ` Jan Kara
2023-07-06 14:01 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 67/92] procfs: " Jeff Layton
2023-07-06 13:59 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 68/92] pstore: " Jeff Layton
2023-07-06 14:00 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 69/92] qnx4: " Jeff Layton
2023-07-06 14:00 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 70/92] qnx6: " Jeff Layton
2023-07-06 14:01 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 71/92] ramfs: " Jeff Layton
2023-07-06 14:01 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 72/92] reiserfs: " Jeff Layton
2023-07-06 14:03 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 73/92] romfs: " Jeff Layton
2023-07-06 14:04 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 74/92] smb: " Jeff Layton
2023-07-05 23:01 ` Jeff Layton
2023-07-06 15:28 ` Steve French
2023-07-05 19:01 ` [PATCH v2 75/92] squashfs: " Jeff Layton
2023-07-06 14:04 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 76/92] sysv: " Jeff Layton
2023-07-06 14:05 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 77/92] tracefs: " Jeff Layton
2023-07-06 14:06 ` Jan Kara
2023-07-06 14:27 ` Steven Rostedt
2023-07-05 19:01 ` [PATCH v2 78/92] ubifs: " Jeff Layton
2023-07-06 12:07 ` Zhihao Cheng
2023-07-06 12:10 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 79/92] udf: " Jeff Layton
2023-07-06 12:57 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 80/92] ufs: " Jeff Layton
2023-07-06 14:49 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 81/92] vboxsf: " Jeff Layton
2023-07-06 14:50 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 82/92] xfs: " Jeff Layton
2023-07-06 14:52 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 83/92] zonefs: " Jeff Layton
2023-07-06 14:52 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 84/92] linux: " Jeff Layton
2023-07-06 14:53 ` Jan Kara
2023-07-06 15:05 ` Jeff Layton
2023-07-05 19:01 ` [PATCH v2 85/92] mqueue: " Jeff Layton
2023-07-06 14:54 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 86/92] bpf: " Jeff Layton
2023-07-06 14:55 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 87/92] shmem: " Jeff Layton
2023-07-06 14:56 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 88/92] sunrpc: " Jeff Layton
2023-07-06 14:56 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 89/92] apparmor: " Jeff Layton
2023-07-06 14:57 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 90/92] security: " Jeff Layton
2023-07-06 14:57 ` Jan Kara
2023-07-05 19:01 ` [PATCH v2 91/92] selinux: " Jeff Layton
2023-07-06 14:57 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705190309.579783-57-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).