linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	ntfs3@lists.linux.dev
Subject: [PATCH v2 61/92] ntfs3: convert to ctime accessor functions
Date: Wed,  5 Jul 2023 15:01:26 -0400	[thread overview]
Message-ID: <20230705190309.579783-59-jlayton@kernel.org> (raw)
In-Reply-To: <20230705190309.579783-1-jlayton@kernel.org>

In later patches, we're going to change how the inode's ctime field is
used. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ntfs3/file.c    |  6 +++---
 fs/ntfs3/frecord.c |  3 ++-
 fs/ntfs3/inode.c   | 14 ++++++++------
 fs/ntfs3/namei.c   |  4 ++--
 fs/ntfs3/xattr.c   |  4 ++--
 5 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c
index 1d6c824246c4..12788601dc84 100644
--- a/fs/ntfs3/file.c
+++ b/fs/ntfs3/file.c
@@ -342,7 +342,7 @@ static int ntfs_extend(struct inode *inode, loff_t pos, size_t count,
 		err = 0;
 	}
 
-	inode->i_ctime = inode->i_mtime = current_time(inode);
+	inode->i_mtime = inode_set_ctime_current(inode);
 	mark_inode_dirty(inode);
 
 	if (IS_SYNC(inode)) {
@@ -400,7 +400,7 @@ static int ntfs_truncate(struct inode *inode, loff_t new_size)
 	ni_unlock(ni);
 
 	ni->std_fa |= FILE_ATTRIBUTE_ARCHIVE;
-	inode->i_ctime = inode->i_mtime = current_time(inode);
+	inode->i_mtime = inode_set_ctime_current(inode);
 	if (!IS_DIRSYNC(inode)) {
 		dirty = 1;
 	} else {
@@ -642,7 +642,7 @@ static long ntfs_fallocate(struct file *file, int mode, loff_t vbo, loff_t len)
 		filemap_invalidate_unlock(mapping);
 
 	if (!err) {
-		inode->i_ctime = inode->i_mtime = current_time(inode);
+		inode->i_mtime = inode_set_ctime_current(inode);
 		mark_inode_dirty(inode);
 	}
 
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 16bd9faa2d28..2b85cb10f0be 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -3265,6 +3265,7 @@ int ni_write_inode(struct inode *inode, int sync, const char *hint)
 	if (is_rec_inuse(ni->mi.mrec) &&
 	    !(sbi->flags & NTFS_FLAGS_LOG_REPLAYING) && inode->i_nlink) {
 		bool modified = false;
+		struct timespec64 ctime = inode_get_ctime(inode);
 
 		/* Update times in standard attribute. */
 		std = ni_std(ni);
@@ -3280,7 +3281,7 @@ int ni_write_inode(struct inode *inode, int sync, const char *hint)
 			modified = true;
 		}
 
-		dup.c_time = kernel2nt(&inode->i_ctime);
+		dup.c_time = kernel2nt(&ctime);
 		if (std->c_time != dup.c_time) {
 			std->c_time = dup.c_time;
 			modified = true;
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index dc7e7ab701c6..4123e126c4d0 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -44,6 +44,7 @@ static struct inode *ntfs_read_mft(struct inode *inode,
 	u64 t64;
 	struct MFT_REC *rec;
 	struct runs_tree *run;
+	struct timespec64 ctime;
 
 	inode->i_op = NULL;
 	/* Setup 'uid' and 'gid' */
@@ -169,7 +170,8 @@ static struct inode *ntfs_read_mft(struct inode *inode,
 		nt2kernel(std5->cr_time, &ni->i_crtime);
 #endif
 		nt2kernel(std5->a_time, &inode->i_atime);
-		nt2kernel(std5->c_time, &inode->i_ctime);
+		ctime = inode_get_ctime(inode);
+		nt2kernel(std5->c_time, &ctime);
 		nt2kernel(std5->m_time, &inode->i_mtime);
 
 		ni->std_fa = std5->fa;
@@ -958,7 +960,7 @@ int ntfs_write_end(struct file *file, struct address_space *mapping, loff_t pos,
 
 	if (err >= 0) {
 		if (!(ni->std_fa & FILE_ATTRIBUTE_ARCHIVE)) {
-			inode->i_ctime = inode->i_mtime = current_time(inode);
+			inode->i_mtime = inode_set_ctime_current(inode);
 			ni->std_fa |= FILE_ATTRIBUTE_ARCHIVE;
 			dirty = true;
 		}
@@ -1658,8 +1660,8 @@ struct inode *ntfs_create_inode(struct mnt_idmap *idmap, struct inode *dir,
 	d_instantiate(dentry, inode);
 
 	/* Set original time. inode times (i_ctime) may be changed in ntfs_init_acl. */
-	inode->i_atime = inode->i_mtime = inode->i_ctime = dir->i_mtime =
-		dir->i_ctime = ni->i_crtime;
+	inode->i_atime = inode->i_mtime = inode_set_ctime_to_ts(inode, ni->i_crtime);
+	dir->i_mtime = inode_set_ctime_to_ts(dir, ni->i_crtime);
 
 	mark_inode_dirty(dir);
 	mark_inode_dirty(inode);
@@ -1765,9 +1767,9 @@ int ntfs_unlink_inode(struct inode *dir, const struct dentry *dentry)
 
 	if (!err) {
 		drop_nlink(inode);
-		dir->i_mtime = dir->i_ctime = current_time(dir);
+		dir->i_mtime = inode_set_ctime_current(dir);
 		mark_inode_dirty(dir);
-		inode->i_ctime = dir->i_ctime;
+		inode_set_ctime_to_ts(inode, inode_get_ctime(dir));
 		if (inode->i_nlink)
 			mark_inode_dirty(inode);
 	} else if (!ni_remove_name_undo(dir_ni, ni, de, de2, undo_remove)) {
diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
index bfd986699f9e..ad430d50bd79 100644
--- a/fs/ntfs3/namei.c
+++ b/fs/ntfs3/namei.c
@@ -156,8 +156,8 @@ static int ntfs_link(struct dentry *ode, struct inode *dir, struct dentry *de)
 	err = ntfs_link_inode(inode, de);
 
 	if (!err) {
-		dir->i_ctime = dir->i_mtime = inode->i_ctime =
-			current_time(dir);
+		dir->i_mtime = inode_set_ctime_to_ts(inode,
+						     inode_set_ctime_current(dir));
 		mark_inode_dirty(inode);
 		mark_inode_dirty(dir);
 		d_instantiate(de, inode);
diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
index 023f314e8950..29fd391899e5 100644
--- a/fs/ntfs3/xattr.c
+++ b/fs/ntfs3/xattr.c
@@ -637,7 +637,7 @@ static noinline int ntfs_set_acl_ex(struct mnt_idmap *idmap,
 	if (!err) {
 		set_cached_acl(inode, type, acl);
 		inode->i_mode = mode;
-		inode->i_ctime = current_time(inode);
+		inode_set_ctime_current(inode);
 		mark_inode_dirty(inode);
 	}
 
@@ -924,7 +924,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler,
 			  NULL);
 
 out:
-	inode->i_ctime = current_time(inode);
+	inode_set_ctime_current(inode);
 	mark_inode_dirty(inode);
 
 	return err;
-- 
2.41.0


  parent reply	other threads:[~2023-07-05 19:11 UTC|newest]

Thread overview: 185+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230705185755.579053-1-jlayton@kernel.org>
2023-07-05 19:00 ` [PATCH v2 01/92] ibmvmc: update ctime in conjunction with mtime on write Jeff Layton
2023-07-05 19:00   ` [PATCH v2 02/92] bfs: update ctime in addition to mtime when adding entries Jeff Layton
2023-07-05 19:00   ` [PATCH v2 03/92] efivarfs: update ctime when mtime changes on a write Jeff Layton
2023-07-05 19:00   ` [PATCH v2 04/92] exfat: ensure that ctime is updated whenever the mtime is Jeff Layton
2023-07-05 19:00   ` [PATCH v2 05/92] apparmor: update ctime whenever the mtime changes on an inode Jeff Layton
2023-07-05 19:00   ` [PATCH v2 06/92] cifs: update the ctime on a partial page write Jeff Layton
     [not found]     ` <CAH2r5mv+Fc9PuNtb8qMTwpb8qrEO2Tta5+o=mxD-2AY0cU5Aeg@mail.gmail.com>
2023-07-06  7:11       ` Christian Brauner
2023-07-06 15:26     ` Steve French
2023-07-05 19:00   ` [PATCH v2 09/92] btrfs: convert to simple_rename_timestamp Jeff Layton
2023-07-05 19:00   ` [PATCH v2 10/92] ubifs: " Jeff Layton
2023-07-06 10:30     ` Jan Kara
2023-07-06 12:08     ` Zhihao Cheng
2023-07-05 19:00   ` [PATCH v2 11/92] shmem: " Jeff Layton
2023-07-06 10:33     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 12/92] exfat: " Jeff Layton
2023-07-06 10:39     ` Jan Kara
2023-07-06 11:40       ` Jeff Layton
2023-07-05 19:00   ` [PATCH v2 13/92] ntfs3: " Jeff Layton
2023-07-06 10:40     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 14/92] reiserfs: " Jeff Layton
2023-07-06 10:32     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 15/92] spufs: convert to ctime accessor functions Jeff Layton
2023-07-06 11:34     ` Arnd Bergmann
2023-07-05 19:00   ` [PATCH v2 16/92] s390: " Jeff Layton
2023-07-12 12:56     ` Alexander Gordeev
2023-07-05 19:00   ` [PATCH v2 17/92] binderfs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 18/92] infiniband: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 19/92] ibm: " Jeff Layton
2023-07-06 10:41     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 20/92] usb: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 21/92] 9p: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 22/92] adfs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 23/92] affs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 24/92] afs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 25/92] fs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 26/92] autofs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 27/92] befs: " Jeff Layton
2023-07-05 19:00   ` [PATCH v2 28/92] bfs: " Jeff Layton
2023-07-06 10:44     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 29/92] btrfs: " Jeff Layton
2023-07-06 10:51     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 30/92] ceph: " Jeff Layton
2023-07-06 10:53     ` Jan Kara
2023-07-06 11:47       ` Jeff Layton
2023-07-05 19:00   ` [PATCH v2 31/92] coda: " Jeff Layton
2023-07-06 10:54     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 32/92] configfs: " Jeff Layton
2023-07-06 10:54     ` Jan Kara
2023-07-06 22:12       ` Joel Becker
2023-07-05 19:00   ` [PATCH v2 33/92] cramfs: " Jeff Layton
2023-07-06 10:55     ` Jan Kara
2023-07-05 19:00   ` [PATCH v2 34/92] debugfs: " Jeff Layton
2023-07-06 10:55     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 35/92] devpts: " Jeff Layton
2023-07-06 10:56     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 36/92] ecryptfs: " Jeff Layton
2023-07-06 10:56     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 37/92] efivarfs: " Jeff Layton
2023-07-06 10:57     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 38/92] efs: " Jeff Layton
2023-07-06 10:57     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 39/92] erofs: " Jeff Layton
2023-07-06 11:00     ` Jan Kara
2023-07-06 11:53       ` Jeff Layton
2023-07-06 15:12       ` Gao Xiang
2023-07-05 19:01   ` [PATCH v2 40/92] exfat: " Jeff Layton
2023-07-06 11:01     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 41/92] ext2: " Jeff Layton
2023-07-06 11:03     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 42/92] ext4: " Jeff Layton
2023-07-06 12:36     ` Jan Kara
2023-07-06 13:10       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 43/92] f2fs: " Jeff Layton
2023-07-06 11:18     ` Jan Kara
2023-09-04 18:11     ` [f2fs-dev] " patchwork-bot+f2fs
2023-07-05 19:01   ` [PATCH v2 44/92] fat: " Jeff Layton
2023-07-06  1:54     ` OGAWA Hirofumi
2023-07-06 11:25       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 45/92] freevxfs: " Jeff Layton
2023-07-06 11:19     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 46/92] fuse: " Jeff Layton
2023-07-06 11:20     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 47/92] gfs2: " Jeff Layton
2023-07-06 12:54     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 48/92] hfs: " Jeff Layton
2023-07-06 12:50     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 49/92] hfsplus: " Jeff Layton
2023-07-06 12:49     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 50/92] hostfs: " Jeff Layton
2023-07-06 12:48     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 51/92] hpfs: " Jeff Layton
2023-07-06 12:47     ` Jan Kara
2023-07-06 13:11       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 52/92] hugetlbfs: " Jeff Layton
2023-07-05 19:58     ` Mike Kravetz
2023-07-06 12:40     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 53/92] isofs: " Jeff Layton
2023-07-06 12:39     ` Jan Kara
2023-07-06 13:11       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 54/92] jffs2: " Jeff Layton
2023-07-06 13:25     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 55/92] jfs: " Jeff Layton
2023-07-06 13:27     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 56/92] kernfs: " Jeff Layton
2023-07-06 13:32     ` Jan Kara
2023-07-06 13:50       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 57/92] nfs: " Jeff Layton
2023-07-06 13:34     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 58/92] nfsd: " Jeff Layton
2023-07-06 13:34     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 59/92] nilfs2: " Jeff Layton
2023-07-06 13:35     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 60/92] ntfs: " Jeff Layton
2023-07-06 13:37     ` Jan Kara
2023-07-05 19:01   ` Jeff Layton [this message]
2023-07-06 13:47     ` [PATCH v2 61/92] ntfs3: " Jan Kara
2023-07-05 19:01   ` [PATCH v2 62/92] ocfs2: " Jeff Layton
2023-07-06 13:51     ` Jan Kara
2023-07-07  3:15     ` Joseph Qi
2023-07-07 10:07       ` Jeff Layton
2023-07-09 13:59         ` Joseph Qi
2023-07-05 19:01   ` [PATCH v2 63/92] omfs: " Jeff Layton
2023-07-06 13:52     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 64/92] openpromfs: " Jeff Layton
2023-07-06 13:52     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 65/92] orangefs: " Jeff Layton
2023-07-06 13:55     ` Jan Kara
2023-07-06 13:56     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 66/92] overlayfs: " Jeff Layton
2023-07-06 13:58     ` Jan Kara
2023-07-06 14:01       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 67/92] procfs: " Jeff Layton
2023-07-06 13:59     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 68/92] pstore: " Jeff Layton
2023-07-06 14:00     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 69/92] qnx4: " Jeff Layton
2023-07-06 14:00     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 70/92] qnx6: " Jeff Layton
2023-07-06 14:01     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 71/92] ramfs: " Jeff Layton
2023-07-06 14:01     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 72/92] reiserfs: " Jeff Layton
2023-07-06 14:03     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 73/92] romfs: " Jeff Layton
2023-07-06 14:04     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 74/92] smb: " Jeff Layton
2023-07-05 23:01     ` Jeff Layton
2023-07-06 15:28     ` Steve French
2023-07-05 19:01   ` [PATCH v2 75/92] squashfs: " Jeff Layton
2023-07-06 14:04     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 76/92] sysv: " Jeff Layton
2023-07-06 14:05     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 77/92] tracefs: " Jeff Layton
2023-07-06 14:06     ` Jan Kara
2023-07-06 14:27     ` Steven Rostedt
2023-07-05 19:01   ` [PATCH v2 78/92] ubifs: " Jeff Layton
2023-07-06 12:07     ` Zhihao Cheng
2023-07-06 12:10       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 79/92] udf: " Jeff Layton
2023-07-06 12:57     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 80/92] ufs: " Jeff Layton
2023-07-06 14:49     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 81/92] vboxsf: " Jeff Layton
2023-07-06 14:50     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 82/92] xfs: " Jeff Layton
2023-07-06 14:52     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 83/92] zonefs: " Jeff Layton
2023-07-06 14:52     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 84/92] linux: " Jeff Layton
2023-07-06 14:53     ` Jan Kara
2023-07-06 15:05       ` Jeff Layton
2023-07-05 19:01   ` [PATCH v2 85/92] mqueue: " Jeff Layton
2023-07-06 14:54     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 86/92] bpf: " Jeff Layton
2023-07-06 14:55     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 87/92] shmem: " Jeff Layton
2023-07-06 14:56     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 88/92] sunrpc: " Jeff Layton
2023-07-06 14:56     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 89/92] apparmor: " Jeff Layton
2023-07-06 14:57     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 90/92] security: " Jeff Layton
2023-07-06 14:57     ` Jan Kara
2023-07-05 19:01   ` [PATCH v2 91/92] selinux: " Jeff Layton
2023-07-06 14:57     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705190309.579783-59-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).