From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D074EB64DD for ; Thu, 6 Jul 2023 10:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbjGFKyg (ORCPT ); Thu, 6 Jul 2023 06:54:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232194AbjGFKyO (ORCPT ); Thu, 6 Jul 2023 06:54:14 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7ACE212C; Thu, 6 Jul 2023 03:53:48 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3367E21DBF; Thu, 6 Jul 2023 10:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688640826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZjAHQzQEXBAzR1upFSNRvl8gRyeGbDUTwY9wKOloKgE=; b=CWhrFcjAtAdPM+hPm4NuypbzXrxFmwxY+zfESBHWW6399J6Jse2UugUhnsjaBcI/tAANYS 2x68Pss3q/xSZClX29KcvJcR8zVVwbMZHhBVbMzOpO15n8d3xtG7iiwjC7l4ztH2pzD+KW SbaxcPmFejmp0j52lAJWdH94Slnofq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688640826; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZjAHQzQEXBAzR1upFSNRvl8gRyeGbDUTwY9wKOloKgE=; b=EcM5kzcX7+KL8yjZXY6iu/zZ38so+JANZAdG7FecAwBdnQE8davIS/Xz0spDkAt5AO8/kf yy6Xchn6z1+zURBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 254B4138EE; Thu, 6 Jul 2023 10:53:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lZ8NCTqdpmRZBAAAMHmgww (envelope-from ); Thu, 06 Jul 2023 10:53:46 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id B0D58A0707; Thu, 6 Jul 2023 12:53:45 +0200 (CEST) Date: Thu, 6 Jul 2023 12:53:45 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Xiubo Li , Ilya Dryomov , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org Subject: Re: [PATCH v2 30/92] ceph: convert to ctime accessor functions Message-ID: <20230706105345.cdoadx7hvb227vts@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-28-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-28-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 05-07-23 15:00:55, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Reviewed-by: Xiubo Li > Signed-off-by: Jeff Layton Just one nit below: > @@ -688,6 +688,7 @@ void ceph_fill_file_time(struct inode *inode, int issued, > struct timespec64 *mtime, struct timespec64 *atime) > { > struct ceph_inode_info *ci = ceph_inode(inode); > + struct timespec64 ictime = inode_get_ctime(inode); > int warn = 0; > > if (issued & (CEPH_CAP_FILE_EXCL| > @@ -696,11 +697,12 @@ void ceph_fill_file_time(struct inode *inode, int issued, > CEPH_CAP_AUTH_EXCL| > CEPH_CAP_XATTR_EXCL)) { > if (ci->i_version == 0 || > - timespec64_compare(ctime, &inode->i_ctime) > 0) { > + timespec64_compare(ctime, &ictime) > 0) { > dout("ctime %lld.%09ld -> %lld.%09ld inc w/ cap\n", > - inode->i_ctime.tv_sec, inode->i_ctime.tv_nsec, > + inode_get_ctime(inode).tv_sec, > + inode_get_ctime(inode).tv_nsec, I think here you can use ictime instead of inode_get_ctime(inode). Otherwise feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR