From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C5BEB64D9 for ; Thu, 6 Jul 2023 10:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232463AbjGFK4g (ORCPT ); Thu, 6 Jul 2023 06:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbjGFK4N (ORCPT ); Thu, 6 Jul 2023 06:56:13 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 875B01FC1; Thu, 6 Jul 2023 03:55:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1795C215EF; Thu, 6 Jul 2023 10:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688640919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Fw2zkW/XtnhiJZRYEgRpg87AdqcKah3pU/8tINpYpY=; b=Pfup790sBjn+YO+jqeBLsW2ICG4tx0ChkUTYmLeK/bvzv/ATv5hNm+cAvaE3C+bDNoXjZ9 xITfdYvprS+S0loiQ54MQJ+HEOuPwiU3KkWocHX4zyJXQpauvL74V6pi4MtZpJYkaPcg1w 464qntPaKOpkHb7kCjN7CnrDnxP2BjM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688640919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3Fw2zkW/XtnhiJZRYEgRpg87AdqcKah3pU/8tINpYpY=; b=Pnl1jR+a7qhpsp0z6FldJvET0kaPlNyuJu0Z2tuDwNTN09gowvW25lEhYm6hhztnGhmFjA YFK6VTUddln7p/Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AF73138EE; Thu, 6 Jul 2023 10:55:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lBSdApedpmRBBQAAMHmgww (envelope-from ); Thu, 06 Jul 2023 10:55:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A5818A0707; Thu, 6 Jul 2023 12:55:18 +0200 (CEST) Date: Thu, 6 Jul 2023 12:55:18 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Nicolas Pitre , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 33/92] cramfs: convert to ctime accessor functions Message-ID: <20230706105518.wdjcbj3wg4t5ejer@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-31-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-31-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 05-07-23 15:00:58, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Acked-by: Nicolas Pitre > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/cramfs/inode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c > index 27c6597aa1be..e755b2223936 100644 > --- a/fs/cramfs/inode.c > +++ b/fs/cramfs/inode.c > @@ -133,7 +133,8 @@ static struct inode *get_cramfs_inode(struct super_block *sb, > } > > /* Struct copy intentional */ > - inode->i_mtime = inode->i_atime = inode->i_ctime = zerotime; > + inode->i_mtime = inode->i_atime = inode_set_ctime_to_ts(inode, > + zerotime); > /* inode->i_nlink is left 1 - arguably wrong for directories, > but it's the best we can do without reading the directory > contents. 1 yields the right result in GNU find, even > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR