From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA37EB64D9 for ; Thu, 6 Jul 2023 11:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232108AbjGFLTX (ORCPT ); Thu, 6 Jul 2023 07:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbjGFLTW (ORCPT ); Thu, 6 Jul 2023 07:19:22 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36B911709; Thu, 6 Jul 2023 04:19:21 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ECA7D21B73; Thu, 6 Jul 2023 11:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688642359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BsfdjJzcVmUmbdUYICzms04Nh4quxK4Q2NAWzm+kkS8=; b=o2oZmklID6Q9VtspxlrERNHrGsJVZtFimQrMkS6qqEX/t7ic1+v74UtfjdX4MbeTo/i/Gs /51COCFZGWnvnP1tXEUtMuV7Uwb5Sq5WWebh12QQiKbiZIQXNgoiQFe0UVDZ1gopFVb/Ub rtmCRNfFvwHfGtA3ad6ftjo+zBBcRmA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688642359; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BsfdjJzcVmUmbdUYICzms04Nh4quxK4Q2NAWzm+kkS8=; b=B15iE44OMhqH2gYIdJjzaGa3KvNAR9a+6V26apUWMXqEM8+X3Oz7wCJOAQRwKqNKJnwZgr zfbF9roSGlolIFBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DB5C5138EE; Thu, 6 Jul 2023 11:19:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LuaINTejpmSVEgAAMHmgww (envelope-from ); Thu, 06 Jul 2023 11:19:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 58DF6A0707; Thu, 6 Jul 2023 13:19:19 +0200 (CEST) Date: Thu, 6 Jul 2023 13:19:19 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Christoph Hellwig , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 45/92] freevxfs: convert to ctime accessor functions Message-ID: <20230706111919.qolfsbnvwiuxbwgo@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-43-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-43-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 05-07-23 15:01:10, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/freevxfs/vxfs_inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/freevxfs/vxfs_inode.c b/fs/freevxfs/vxfs_inode.c > index ceb6a12649ba..ac5d43b164b5 100644 > --- a/fs/freevxfs/vxfs_inode.c > +++ b/fs/freevxfs/vxfs_inode.c > @@ -110,10 +110,9 @@ static inline void dip2vip_cpy(struct vxfs_sb_info *sbi, > inode->i_size = vip->vii_size; > > inode->i_atime.tv_sec = vip->vii_atime; > - inode->i_ctime.tv_sec = vip->vii_ctime; > + inode_set_ctime(inode, vip->vii_ctime, 0); > inode->i_mtime.tv_sec = vip->vii_mtime; > inode->i_atime.tv_nsec = 0; > - inode->i_ctime.tv_nsec = 0; > inode->i_mtime.tv_nsec = 0; > > inode->i_blocks = vip->vii_blocks; > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR