From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F852C0015E for ; Thu, 6 Jul 2023 14:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233370AbjGFOxi (ORCPT ); Thu, 6 Jul 2023 10:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233806AbjGFOx2 (ORCPT ); Thu, 6 Jul 2023 10:53:28 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21F93119; Thu, 6 Jul 2023 07:53:23 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D03C3210E1; Thu, 6 Jul 2023 14:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688655201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dP1By/QzEGxAeYtguefHAZ6uwBGuUVygTSGRjgis6XE=; b=FaPRDhoi2U0VRQso5o9hAktyVk1QfhvMoczxP18FW1iIMjSWTVShaVi/mF4w+k/tQc1dO7 gQyn//fa9/ys74l4nQrsznRm+PzeyXwVFakK4E6rm6lylacKH4EJ+dvddC9m7BcohshC3X H4Dxh5fgQDQperv6VODcRi0b7DcfEFE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688655201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dP1By/QzEGxAeYtguefHAZ6uwBGuUVygTSGRjgis6XE=; b=jsRXgiMQn8cqSiQslJ6zHZ9pMlrQwPF/KXYUVFWqPFqqDsLP/aPw7LIXY8XulZQ6aejP7a R9TKUukgtusvXaBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3587138FC; Thu, 6 Jul 2023 14:53:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8p+vL2HVpmStAwAAMHmgww (envelope-from ); Thu, 06 Jul 2023 14:53:21 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6BADAA0707; Thu, 6 Jul 2023 16:53:21 +0200 (CEST) Date: Thu, 6 Jul 2023 16:53:21 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 84/92] linux: convert to ctime accessor functions Message-ID: <20230706145321.ahfawgtukrmfgfdv@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-82-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-82-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 05-07-23 15:01:49, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/fs_stack.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs_stack.h b/include/linux/fs_stack.h > index 54210a42c30d..010d39d0dc1c 100644 > --- a/include/linux/fs_stack.h > +++ b/include/linux/fs_stack.h > @@ -24,7 +24,7 @@ static inline void fsstack_copy_attr_times(struct inode *dest, > { > dest->i_atime = src->i_atime; > dest->i_mtime = src->i_mtime; > - dest->i_ctime = src->i_ctime; > + inode_set_ctime_to_ts(dest, inode_get_ctime(src)); > } > > #endif /* _LINUX_FS_STACK_H */ > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR