From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D14EB64DD for ; Thu, 6 Jul 2023 14:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233684AbjGFO6T (ORCPT ); Thu, 6 Jul 2023 10:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232479AbjGFO5y (ORCPT ); Thu, 6 Jul 2023 10:57:54 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90E171BF9; Thu, 6 Jul 2023 07:57:50 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBE02211CE; Thu, 6 Jul 2023 14:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688655468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQy4r3jBeJ1GrUGNs17Ib9ABW1DTjrqpCUtgNF657N8=; b=hbvDgJ9k2D2Wi488tTmSp6AiIH5C7387dN+FFa37omvU6n6Wllm3JjFSUUIcj85xNWVYu8 4uw+58dmK828uqi5dHWA/NEHOK2VgOrsIvAs3KHhZigo+VsQqn9GB0lNY+Is+YrWQYgXT2 ZollszzcHjyXYpRw9I+7pvgBH2IwucY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688655468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQy4r3jBeJ1GrUGNs17Ib9ABW1DTjrqpCUtgNF657N8=; b=JR83XE7n8Drd25aq3i3IdZWpBXZn5NPqwfXy1Eze6lRBqCZPLLGf+RlNzKq3KHN7C4+bUV Qj3Qai12hqwV5FCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D88DF138FC; Thu, 6 Jul 2023 14:57:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lRvJNGzWpmQOBgAAMHmgww (envelope-from ); Thu, 06 Jul 2023 14:57:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 6BF24A0707; Thu, 6 Jul 2023 16:57:48 +0200 (CEST) Date: Thu, 6 Jul 2023 16:57:48 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Paul Moore , Stephen Smalley , Eric Paris , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v2 91/92] selinux: convert to ctime accessor functions Message-ID: <20230706145748.p6ncrphpbxt2hlaz@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-89-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-89-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed 05-07-23 15:01:56, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Acked-by: Paul Moore > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > security/selinux/selinuxfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c > index bad1f6b685fd..9dafb6ff110d 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c > @@ -1197,7 +1197,7 @@ static struct inode *sel_make_inode(struct super_block *sb, int mode) > > if (ret) { > ret->i_mode = mode; > - ret->i_atime = ret->i_mtime = ret->i_ctime = current_time(ret); > + ret->i_atime = ret->i_mtime = inode_set_ctime_current(ret); > } > return ret; > } > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR